Aw: [PATCH 21/29] arm: dts: medaitek: convert gmac link mode to 2500base-x

[Frank Wunderlich]

Hi

> Gesendet: Mittwoch, 19. Juli 2023 um 11:17 Uhr
> Von: "Weijie Gao" <weijie.gao at mediatek.com>
> An: u-boot at lists.denx.de
> Cc: "GSS_MTK_Uboot_upstream" <GSS_MTK_Uboot_upstream at mediatek.com>, "Daniel Golle" <daniel at makrotopia.org>, "Frank Wunderlich" <linux at fw-web.de>, "Weijie Gao" <weijie.gao at mediatek.com>
> Betreff: [PATCH 21/29] arm: dts: medaitek: convert gmac link mode to 2500base-x
>
> Now that individual 2.5Gbps SGMII support has been added to
> mtk-eth, all boards that use 2.5Gbps link with mt7531 must be
> converted to use "2500base-x" instead of "sgmii".
>
> Signed-off-by: Weijie Gao <weijie.gao at mediatek.com>
> ---
>  arch/arm/dts/mt7622-bananapi-bpi-r64.dts | 4 ++--
>  arch/arm/dts/mt7622-rfb.dts              | 4 ++--
>  arch/arm/dts/mt7629-rfb.dts              | 4 ++--
>  arch/arm/dts/mt7981-emmc-rfb.dts         | 4 ++--
>  arch/arm/dts/mt7981-rfb.dts              | 4 ++--
>  arch/arm/dts/mt7981-sd-rfb.dts           | 4 ++--
>  arch/arm/dts/mt7986a-rfb.dts             | 4 ++--
>  arch/arm/dts/mt7986a-sd-rfb.dts          | 4 ++--
>  arch/arm/dts/mt7986b-rfb.dts             | 4 ++--
>  arch/arm/dts/mt7986b-sd-rfb.dts          | 4 ++--

you miss arch/arm/dts/mt7986a-bpi-r3-sd.dts here which was added in 2023.07

i tested series on Bananapi-R4/mt7988, sdcard and network-support (many thx for this) works so far (not tested i2c, spi and others yet), also have not done tests on my other boards yet.

noticed some build-warnings from the pinctrl-patch which are not critical, but should be fixed.

e.g. this (seems for each call of PINCTRL_PIN_GROUP)

drivers/pinctrl/mediatek/pinctrl-mt7988.c:1148:42: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
 1148 |  PINCTRL_PIN_GROUP("net_wo1_uart_txd_1", mt7988_net_wo1_uart_txd_1),
      |                                          ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/mediatek/pinctrl-mtk-common.h:31:3: note: in definition of macro 'PINCTRL_PIN_GROUP'
   31 |   id##_funcs,      \
      |   ^~


regards Frank