[PATCH] net: axi_emac: Change return value to -EAGAIN if RX is not ready

Michal Simek michal.simek at amd.com
Wed Jul 19 15:54:46 CEST 2023



On 7/19/23 08:53, Maksim Kiselev wrote:
> If there is no incoming package than axiemac_recv will return -1 which
> in turn leads to printing `eth_rx: recv() returned error -1` error
> message in eth_rx function. But missing a package is not an fatal error,
> so return -EAGAIN in that case would be more suitable.
> 
> Signed-off-by: Maksim Kiselev <bigunclemax at gmail.com>
> ---
>   drivers/net/xilinx_axi_emac.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/xilinx_axi_emac.c b/drivers/net/xilinx_axi_emac.c
> index 3e9919993d..39cb3cc260 100644
> --- a/drivers/net/xilinx_axi_emac.c
> +++ b/drivers/net/xilinx_axi_emac.c
> @@ -748,7 +748,7 @@ static int axiemac_recv(struct udevice *dev, int flags, uchar **packetp)
>   
>   	/* Wait for an incoming packet */
>   	if (!isrxready(priv))
> -		return -1;
> +		return -EAGAIN;
>   
>   	debug("axiemac: RX data ready\n");
>   

Make sense. Applied.
M


More information about the U-Boot mailing list