[PATCH v4 1/2] board/km/cent2: add include common.h

Simon Glass sjg at google.com
Wed Jul 19 21:11:30 CEST 2023


On Wed, 19 Jul 2023 at 07:46, <christian.taedcke-oss at weidmueller.com> wrote:
>
> From: Christian Taedcke <christian.taedcke at weidmueller.com>
>
> Including common.h before event.h is required, because the new fpga
> load event in event.h uses the size_t type.
>
> Signed-off-by: Christian Taedcke <christian.taedcke at weidmueller.com>
> ---
>
> Changes in v4:
> - add include common.h to kmcent2 board file
>
>  board/keymile/kmcent2/kmcent2.c | 1 +
>  1 file changed, 1 insertion(+)
>

This is fine, but really we should fix event.h

Reviewed-by: Simon Glass <sjg at chromium.org>


> diff --git a/board/keymile/kmcent2/kmcent2.c b/board/keymile/kmcent2/kmcent2.c
> index ed552c57b5..6dbaaa5457 100644
> --- a/board/keymile/kmcent2/kmcent2.c
> +++ b/board/keymile/kmcent2/kmcent2.c
> @@ -6,6 +6,7 @@
>   * Copyright 2013 Freescale Semiconductor, Inc.
>   */
>
> +#include <common.h>
>  #include <event.h>
>  #include <asm/cache.h>
>  #include <asm/fsl_fdt.h>
> --
> 2.34.1
>


More information about the U-Boot mailing list