[PATCH v4 08/83] buildman: Add a test for Boards.output_is_new()

Simon Glass sjg at chromium.org
Thu Jul 20 01:48:16 CEST 2023


Add a test for this code, adjusting the timestamp on various files to
check each use case.

Signed-off-by: Simon Glass <sjg at chromium.org>
---

(no changes since v3)

Changes in v3:
- Add new patch with a test for Boards.output_is_new()

 tools/buildman/func_test.py | 61 +++++++++++++++++++++++++++++++++++++
 1 file changed, 61 insertions(+)

diff --git a/tools/buildman/func_test.py b/tools/buildman/func_test.py
index d423457ea24a..70e2af19fd46 100644
--- a/tools/buildman/func_test.py
+++ b/tools/buildman/func_test.py
@@ -3,9 +3,11 @@
 #
 
 import os
+from pathlib import Path
 import shutil
 import sys
 import tempfile
+import time
 import unittest
 
 from buildman import board
@@ -816,3 +818,62 @@ CONFIG_LOCALVERSION=y
         self.assertEquals('config2', board2['config'])
         self.assertEquals('board2', board2['target'])
 
+    def test_output_is_new(self):
+        """Test detecting new changes to Kconfig"""
+        base = self._base_dir
+        src = self._git_dir
+        config_dir = os.path.join(src, 'configs')
+        delay = 0.02
+
+        # Create a boards.cfg file
+        boards_cfg = os.path.join(base, 'boards.cfg')
+        content = b'''#
+# List of boards
+#   Automatically generated by buildman/boards.py: don't edit
+#
+# Status, Arch, CPU, SoC, Vendor, Board, Target, Config, Maintainers
+
+Active  aarch64     armv8 - armltd corstone1000 board0
+Active  aarch64     armv8 - armltd total_compute board2
+'''
+        # Check missing file
+        self.assertFalse(boards.output_is_new(boards_cfg, config_dir, src))
+
+        # Check that the board.cfg file is newer
+        time.sleep(delay)
+        tools.write_file(boards_cfg, content)
+        self.assertTrue(boards.output_is_new(boards_cfg, config_dir, src))
+
+        # Touch the Kconfig files after a show delay to avoid a race
+        time.sleep(delay)
+        Path(os.path.join(src, 'Kconfig')).touch()
+        self.assertFalse(boards.output_is_new(boards_cfg, config_dir, src))
+        Path(boards_cfg).touch()
+        self.assertTrue(boards.output_is_new(boards_cfg, config_dir, src))
+
+        # Touch a different Kconfig file
+        time.sleep(delay)
+        Path(os.path.join(src, 'Kconfig.something')).touch()
+        self.assertFalse(boards.output_is_new(boards_cfg, config_dir, src))
+        Path(boards_cfg).touch()
+        self.assertTrue(boards.output_is_new(boards_cfg, config_dir, src))
+
+        # Touch a MAINTAINERS file
+        time.sleep(delay)
+        Path(os.path.join(src, 'MAINTAINERS')).touch()
+        self.assertFalse(boards.output_is_new(boards_cfg, config_dir, src))
+
+        Path(boards_cfg).touch()
+        self.assertTrue(boards.output_is_new(boards_cfg, config_dir, src))
+
+        # Touch a defconfig file
+        time.sleep(delay)
+        Path(os.path.join(config_dir, 'board0_defconfig')).touch()
+        self.assertFalse(boards.output_is_new(boards_cfg, config_dir, src))
+        Path(boards_cfg).touch()
+        self.assertTrue(boards.output_is_new(boards_cfg, config_dir, src))
+
+        # Remove a board and check that the board.cfg file is now older
+        Path(os.path.join(config_dir, 'board0_defconfig')).unlink()
+        self.assertFalse(boards.output_is_new(boards_cfg, config_dir, src))
+
-- 
2.41.0.487.g6d72f3e995-goog



More information about the U-Boot mailing list