[PATCH v4 43/83] buildman: Avoid too many returns in do_buildman()
Simon Glass
sjg at chromium.org
Thu Jul 20 01:48:51 CEST 2023
Fix the pylint warning by using a variable instead of lots of 'return'
statements.
Signed-off-by: Simon Glass <sjg at chromium.org>
---
(no changes since v1)
tools/buildman/control.py | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/tools/buildman/control.py b/tools/buildman/control.py
index 51dc6fe7ce73..44a96cfb7a06 100644
--- a/tools/buildman/control.py
+++ b/tools/buildman/control.py
@@ -602,15 +602,16 @@ def do_buildman(options, args, toolchains=None, make_func=None, brds=None,
options.show_bloat, options.list_error_boards, options.show_config,
options.show_environment, options.filter_dtb_warnings,
options.filter_migration_warnings, options.ide)
+ retval = 0
if options.summary:
builder.ShowSummary(commits, board_selected)
else:
fail, warned, excs = builder.BuildBoards(
commits, board_selected, options.keep_outputs, options.verbose)
if excs:
- return 102
+ retval = 102
if fail:
- return 100
+ retval = 100
if warned and not options.ignore_warnings:
- return 101
- return 0
+ retval = 101
+ return retval
--
2.41.0.487.g6d72f3e995-goog
More information about the U-Boot
mailing list