[PATCH] usb: cdns3: gadget: Configure speed in udc_start

Marek Vasut marex at denx.de
Fri Jul 21 02:02:57 CEST 2023


On 7/19/23 13:06, Ravi Gunasekaran wrote:
> 
> 
> On 7/19/23 4:03 PM, Marek Vasut wrote:
>> On 7/19/23 10:59, Ravi Gunasekaran wrote:
>>> When one of the functions does not support super speed, the composite
>>> driver forces the gadget to high speed. But the speed is never
>>> configured in the cdns3 gadget driver. So configure the speed
>>> in cdns3_gadget_udc_start just like in the kernel.
>>>
>>> Signed-off-by: Ravi Gunasekaran <r-gunasekaran at ti.com>
>>
>> Is this a patch picked from the kernel ?
>> Is there a matching kernel commit ID ?
> 
> The commit 4df50f89f5 ("usb: composite: force gadget to be USB2 for HS only function")
> in u-boot, forces the gadget's max speed to high speed and had a mention in the commit
> description that the gadget's udc_start would configure itself in USB 2.0.
> 
> I checked the cdns3 gadget driver in kernel, and the cdns3_gadget_udc_start()
> configures speed. So this is not a patch picked directly from the kernel. I used
> kernel code for reference.

Thanks for clarification.

Reviewed-by: Marek Vasut <marex at denx.de>


More information about the U-Boot mailing list