[PATCH 4/4] fixup! arm: dts: k3-am62: Bump dtsi from linux v6.5-rc1

Maxime Ripard mripard at kernel.org
Fri Jul 21 09:46:10 CEST 2023


On Thu, Jul 20, 2023 at 06:27:56PM +0300, Roger Quadros wrote:
> 
> 
> On 20/07/2023 12:55, Maxime Ripard wrote:
> > Dropping ranges entirely doesn't work since the register offset on the
> > MDIO device node will now be completely off, so we need to adjust it to
> > the right value without the translation.
> > 
> > We also need to have an empty ranges property for the reg address to be
> > properly evaluated.
> > 
> > Signed-off-by: Maxime Ripard <mripard at kernel.org>
> > ---
> >  arch/arm/dts/k3-am625-sk-u-boot.dtsi | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/dts/k3-am625-sk-u-boot.dtsi b/arch/arm/dts/k3-am625-sk-u-boot.dtsi
> > index fe1c7408a89d..2ec3fff99f32 100644
> > --- a/arch/arm/dts/k3-am625-sk-u-boot.dtsi
> > +++ b/arch/arm/dts/k3-am625-sk-u-boot.dtsi
> > @@ -122,8 +122,8 @@
> >  	reg = <0x0 0x8000000 0x0 0x200000>,
> >  	      <0x0 0x43000200 0x0 0x8>;
> >  	reg-names = "cpsw_nuss", "mac_efuse";
> > -	/delete-property/ ranges;
> >  	bootph-pre-ram;
> > +	ranges;
> >  
> >  	cpsw-phy-sel at 04044 {
> >  		compatible = "ti,am64-phy-gmii-sel";
> > @@ -132,6 +132,10 @@
> >  	};
> >  };
> >  
> > +&cpsw3g_mdio {
> > +	reg = <0x0 0x8000f00 0x0 0x100>;
> > +};
> > +
> 
> Why this change?
> 
> Linux DT has
>                 cpsw3g_mdio: mdio at f00 {
>                         compatible = "ti,cpsw-mdio","ti,davinci_mdio";
>                         reg = <0x00 0xf00 0x00 0x100>;
> 
> And it is a child of cpsw3g node.

Right, but Linux also has on the cpsw3g node:
ranges = <0x00 0x00 0x00 0x08000000 0x00 0x200000>;

Which means that child node don't get a 1:1 mapping but we get a
0x08000000 offset.

Nishanth's patch was removing the ranges property because the
translation is troublesome for the new cpsw-phy-sel at 04044 node (I
assume), so we need to add the offset to the mdio node so that it still
expresses the same base address.

Maxime
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20230721/6dd28d46/attachment.sig>


More information about the U-Boot mailing list