[PATCH v1] net: sun8i-emac: Add support for fixed-link phy

Ramon Fried rfried.dev at gmail.com
Sat Jul 22 10:20:23 CEST 2023


On Thu, Jun 15, 2023 at 12:51 AM Maxim Kiselev <bigunclemax at gmail.com> wrote:
>
> From: Maksim Kiselev <bigunclemax at gmail.com>
>
> Based on dt-specs fixed-link doesn't require phy-handle to be used.
> Fix driver to only read phy related setting when phy-handle is found.
>
> Signed-off-by: Maksim Kiselev <bigunclemax at gmail.com>
> ---
>  drivers/net/sun8i_emac.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/sun8i_emac.c b/drivers/net/sun8i_emac.c
> index 04c3274fbe..0e339d69e0 100644
> --- a/drivers/net/sun8i_emac.c
> +++ b/drivers/net/sun8i_emac.c
> @@ -834,11 +834,8 @@ static int sun8i_emac_eth_of_to_plat(struct udevice *dev)
>         priv->use_internal_phy = false;
>
>         offset = fdtdec_lookup_phandle(gd->fdt_blob, node, "phy-handle");
> -       if (offset < 0) {
> -               debug("%s: Cannot find PHY address\n", __func__);
> -               return -EINVAL;
> -       }
> -       priv->phyaddr = fdtdec_get_int(gd->fdt_blob, offset, "reg", -1);
> +       if (offset >= 0)
> +               priv->phyaddr = fdtdec_get_int(gd->fdt_blob, offset, "reg", -1);
>
>         pdata->phy_interface = dev_read_phy_mode(dev);
>         debug("phy interface %d\n", pdata->phy_interface);
> --
> 2.39.2
>
Reviewed-by: Ramon Fried <rfried.dev at gmail.com>


More information about the U-Boot mailing list