[PATCH v2 2/6] net: prepare existing TCP stack to be reused by IP6

[Simon Glass]

Hi Dmitrii,

On Wed, 10 May 2023 at 11:00, Dmitrii Merkurev <dimorinny at google.com> wrote:
>
> Changes:
> 1. Separate reusable part from net_set_tcp_header to
> net_set_tcp_header_common
> 2. Make TCP signatures reusable by receiving particular
> IP agnostic TCP headers
> 3. Extract net_send_ip_packet6 from net_send_udp_packet6
> to reuse the code
> 4. Expose TCP state machine related functions
>
> This allows us to reuse TCP logic between IP and IP6 stack.
>
> Signed-off-by: Dmitrii Merkurev <dimorinny at google.com>
> Cc: Ying-Chun Liu (PaulLiu) <paul.liu at linaro.org>
> Cc: Simon Glass <sjg at chromium.org>
> Сс: Joe Hershberger <joe.hershberger at ni.com>
> Сс: Ramon Fried <rfried.dev at gmail.com>
> ---
>  include/net/tcp.h | 109 +++++++++++++--
>  net/net.c         |  18 ++-
>  net/net6.c        |  78 ++++++++---
>  net/tcp.c         | 337 ++++++++++++++++++++++++++++------------------
>  4 files changed, 372 insertions(+), 170 deletions(-)

Reviewed-by: Simon Glass <sjg at chromium.org>

While you are here, or in a follow-up patch, can you please add full
comments to net_set_ip_header(), e,g. what is the pkt param exactly?
The whole packet, before any headers?