[PATCH 18/18] riscv: qemu: Enable usb keyboard as an input device

[Bin Meng]

Hi Heinrich,

On Sun, Jul 23, 2023 at 2:11 PM Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>
>
>
> Am 23. Juli 2023 06:40:41 MESZ schrieb Bin Meng <bmeng at tinylab.org>:
> >This brings PCI xHCI support to QEMU RISC-V and uses a usb keyboard
> >as one of the input devices.
> >
> >Signed-off-by: Bin Meng <bmeng at tinylab.org>
> >
> >---
> >
> > board/emulation/qemu-riscv/Kconfig      | 5 +++++
> > board/emulation/qemu-riscv/qemu-riscv.c | 5 +++++
> > doc/board/emulation/qemu-riscv.rst      | 5 +++++
> > include/configs/qemu-riscv.h            | 2 +-
> > 4 files changed, 16 insertions(+), 1 deletion(-)
> >
> >diff --git a/board/emulation/qemu-riscv/Kconfig b/board/emulation/qemu-riscv/Kconfig
> >index 7220c55350..b503578d27 100644
> >--- a/board/emulation/qemu-riscv/Kconfig
> >+++ b/board/emulation/qemu-riscv/Kconfig
> >@@ -76,5 +76,10 @@ config BOARD_SPECIFIC_OPTIONS # dummy
> >       imply VIDEO_BOCHS
> >       imply SYS_WHITE_ON_BLACK
> >       imply PRE_CONSOLE_BUFFER
> >+      imply USB
> >+      imply USB_XHCI_HCD
> >+      imply USB_XHCI_PCI
>
> QEMU could alternatively use EHCI or OHCI for the keyboard. Does enabling XHCI add support for these too?

No, EHCI or OHCI support is separate from xHCI. I don't think enabling
EHCI or OHCI *by default* brings a lot of value here as xHCI is the
latest and greatest and USB keyboard could work with xHCI without any
problem.

Regards,
Bin