[PATCH v3 5/7] power: regulator: tps80031: add regulator support

Simon Glass sjg at chromium.org
Mon Jul 24 04:28:20 CEST 2023


Hi Svyatoslav,

On Sun, 23 Jul 2023 at 06:28, Svyatoslav Ryhel <clamor95 at gmail.com> wrote:
>
> The driver provides regulator set/get voltage enable/disable
> functions for TI TPS80031/TPS80032 PMICs.
>
> Signed-off-by: Svyatoslav Ryhel <clamor95 at gmail.com>
> ---
>  drivers/power/regulator/Kconfig              |   8 +
>  drivers/power/regulator/Makefile             |   1 +
>  drivers/power/regulator/tps80031_regulator.c | 296 +++++++++++++++++++
>  3 files changed, 305 insertions(+)
>  create mode 100644 drivers/power/regulator/tps80031_regulator.c

Reviewed-by: Simon Glass <sjg at chromium.org>

This is quite nice code. Consider the 'p' suffix for return vars and
also the meaning of 'hex'.

Regards,
Simon


More information about the U-Boot mailing list