[u-boot][PATCH] board: at91: sama5d29_curiosity: add initial support for sama5d29_curiosity

Eugen Hristev eugen.hristev at collabora.com
Mon Jul 24 10:52:57 CEST 2023



On 7/24/23 11:49, Mihai.Sain at microchip.com wrote:
> Hello Eugen,
> 
> Thank you for applying the patch.
> 
> For this board we don't want to use SPL.
> I will send v2 patch to remove the custom prompt.
> Thanks.

As I said, I won't be applying any patches to at91 tree unless someone 
helps with the testing below. SPL for this board has nothing to do with 
my request.

These also have to be removed:

+
+#define CONFIG_SYS_SDRAM_BASE		0x20000000
+#define CONFIG_SYS_SDRAM_SIZE		0x20000000

as they are forbidden to set in the config file and appear to be unused 
anyway.

Eugen

> 
> Best regards,
> Mihai Sain
> 
> -----Original Message-----
> From: Eugen Hristev <eugen.hristev at collabora.com>
> Sent: Monday, July 24, 2023 11:13 AM
> To: Mihai Sain - M19926 <Mihai.Sain at microchip.com>; u-boot at lists.denx.de
> Cc: Cristian Birsan - M91496 <Cristian.Birsan at microchip.com>
> Subject: Re: [u-boot][PATCH] board: at91: sama5d29_curiosity: add initial support for sama5d29_curiosity
> 
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Hello Mihai,
> 
> Thank you for the patch.
> 
> However, the at91 maintainer tree nowadays has a big problem, I cannot apply patches because the size of the SPL will overflow.
> There is a pending patch that fixes it, but it has not been tested.
> Here you can help, and test this integration branch (at least on sama5d2 ICP, but if you can test on multiple boards, it's even better) :
> 
> https://source.denx.de/u-boot/custodians/u-boot-at91/-/tree/testing?ref_type=heads
> 
> Once this is tested you can reply with a Tested-by: tag, and we can move along.
> Without testing the patch that fixes the size restraint (it's the CONFIG_LTO patch), the tree is stalled.
> 
> One small nitpick below, and I am looking forward for your reply,
> 
> Eugen
> 
> 
> On 7/20/23 10:54, Mihai Sain wrote:
>> Add initial support for sama5d29_curiosity board.
>>
>> Hardware:
>> SoC: SAMA5D29 500 MHz
>> DRAM: LPDDR2 512 MiB
>> PMIC: MCP16502
>> Debug: UART0
>> Flash: QSPI NOR 8 MiB
>> RGB LCD connector
>> Mikrobus connectors x 2
>> SD-Card connectors x 2
>> USB 2.0 x 2
>>
>> Signed-off-by: Mihai Sain <mihai.sain at microchip.com>
>> ---
> 
>> +CONFIG_SYS_PROMPT="[root at sama5d29 ~]$ "
> 
> Can you remove this. It looks like a Linux prompt and might be confusing for people
> 
> (and everywhere below)



More information about the U-Boot mailing list