[PATCH] spl: CONFIG_SPL_PCI_PNP should depend on CONFIG_SPL_PCI

[Tom Rini]

On Mon, Jul 24, 2023 at 07:46:09PM +0200, Heinrich Schuchardt wrote:
> On 24.07.23 17:14, Tom Rini wrote:
> > On Mon, Jul 24, 2023 at 09:03:10AM +0200, Heinrich Schuchardt wrote:
> > > CONFIG_SPL_PCI_PNP=y without CONFIG_SPL_PCI=y makes no sense.
> > > 
> > > Move CONFIG_SPL_PCI_PNP to the SPL menu and add the missing dependency.
> > > 
> > > Fixes: 32f5e9e5c1a7 ("nvme: pci: Enable for SPL")
> > > Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
> > > ---
> > >   common/spl/Kconfig  | 12 ++++++++++++
> > >   drivers/pci/Kconfig | 11 -----------
> > >   2 files changed, 12 insertions(+), 11 deletions(-)
> > 
> > Lets not move this out of drivers/pci/Kconfig, just add the dependency.
> > 
> 
> Hello Tom,
> 
> when you configure boot methods you will enable SPL_PCI and with the patch
> SPL_PCI_PNP  will pop up beneath. If you leave SPL_PCI_PNP in the old place,
> you will have a hard time figuring out why yout PCI is not working.
> 
> Why would you prefer to keep SPL_PCI_PNP  outside of the SPL menu?

We should move SPL_PCI out of common/spl/Kconfig as well then.  It's
1500 lines, and yes there's likely more options still that should be
moved out.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20230724/28464bba/attachment.sig>