[PATCH] fs/erofs: Introduce new features including ztailpacking, fragments and dedupe

Sam Edwards cfsworks at gmail.com
Tue Jul 25 23:40:45 CEST 2023


Hi folks,

On 7/7/23 09:52, Yifan Zhao wrote:
> diff --git a/fs/erofs/internal.h b/fs/erofs/internal.h
> index 4af7c91560..433a3c6c1e 100644
> --- a/fs/erofs/internal.h
> +++ b/fs/erofs/internal.h
> +/* make sure that any user of the erofs headers has at least 64bit off_t type */
> +extern int erofs_assert_largefile[sizeof(off_t) - 8];

This assertion does not hold true on 32-bit platforms, and as a result 
this patch prevents building U-Boot on those systems with EROFS support 
enabled. Did you perhaps mean to use `erofs_off_t` (which is always 
64-bit) somewhere that you're using `off_t` instead?

I have had to revert this patch on my target, pending a solution for 
32-bit users.

Thanks,
Sam


More information about the U-Boot mailing list