[PATCH v5 10/12] test: capsule: Remove public key embed logic from capsule update test

[Simon Glass]

On Tue, 25 Jul 2023 at 02:58, Sughosh Ganu <sughosh.ganu at linaro.org> wrote:
>
> The embedding of the public key EFI Signature List(ESL) file into the
> platform's DTB is now done at the time of u-boot build. Remove this
> logic from the capsule update test' configuration.
>
> Include the public key for the sandbox and sandbox_flattree variant
> as part of the build.
>
> Signed-off-by: Sughosh Ganu <sughosh.ganu at linaro.org>
> ---
> Changes since V4: None
>
>  configs/sandbox_defconfig                    |  1 +
>  configs/sandbox_flattree_defconfig           |  1 +
>  test/py/tests/test_efi_capsule/conftest.py   | 37 ++++----------------
>  test/py/tests/test_efi_capsule/signature.dts | 10 ------
>  4 files changed, 9 insertions(+), 40 deletions(-)
>  delete mode 100644 test/py/tests/test_efi_capsule/signature.dts
>
> diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig
> index 19cc6701e6..53e342b3fa 100644
> --- a/configs/sandbox_defconfig
> +++ b/configs/sandbox_defconfig
> @@ -342,6 +342,7 @@ CONFIG_EFI_RUNTIME_UPDATE_CAPSULE=y
>  CONFIG_EFI_CAPSULE_ON_DISK=y
>  CONFIG_EFI_CAPSULE_FIRMWARE_RAW=y
>  CONFIG_EFI_CAPSULE_AUTHENTICATE=y
> +CONFIG_EFI_CAPSULE_ESL_FILE="/tmp/capsules/SIGNER.esl"

No, we cannot use hard-coded pathnames, still.

Please grep for /tmp/capsules throughout your series.

You should be able to drop the path if you put the file in the right
dir in the test. It runs in the working directory, I believe.

[..]

Regards,
Simon