[PATCH] configs: rockchip: drop useless DEBUG_UART_SKIP_INIT
Kever Yang
kever.yang at rock-chips.com
Wed Jul 26 04:23:51 CEST 2023
On 2023/7/17 00:53, Pegorer Massimo wrote:
> DEBUG_UART_SKIP_INIT feature is implemented only by s5p (DEBUG_UART_S5P)
> and pl01x (DEBUG_UART_PL010 or DEBUG_UART_PL011) serial drivers, but all
> ARCH_ROCKCHIP configs rely on default DEBUG_UART_NS16550. The ns16550
> serial driver does not depends on DEBUG_UART_SKIP_INIT, so drop it from
> rockchip configs.
>
> Signed-off-by: Massimo Pegorer <massimo.pegorer at vimar.com>
Reviewed-by: Kever Yang <kever.yang at rock-chips.com>
Thanks,
- Kever
> ---
>
> I have tested this building all of next configs, and the resulting images
> do not depend on DEBUG_UART_SKIP_INIT (i.e. they are the same with or
> without DEBUG_UART_SKIP_INIT), as expected.
>
> IMO, DEBUG_UART_SKIP_INIT name and its description seem a little bit
> misleading, as suggesting this feature provides skipping debug uart init
> at all, while instead its related just to skip init of serial driver used
> for debug uart. BTW maybe depends on DEBUG_UART_PL010 || DEBUG_UART_PL011
> || DEBUG_UART_S5P can be added to DEBUG_UART_SKIP_INIT.
>
> configs/evb-px30_defconfig | 1 -
> configs/evb-px5_defconfig | 1 -
> configs/evb-rk3308_defconfig | 1 -
> configs/evb-rk3328_defconfig | 1 -
> configs/firefly-px30_defconfig | 1 -
> configs/geekbox_defconfig | 1 -
> configs/lion-rk3368_defconfig | 1 -
> configs/odroid-go2_defconfig | 1 -
> configs/px30-core-ctouch2-of10-px30_defconfig | 1 -
> configs/px30-core-ctouch2-px30_defconfig | 1 -
> configs/px30-core-edimm2.2-px30_defconfig | 1 -
> configs/ringneck-px30_defconfig | 1 -
> configs/roc-cc-rk3308_defconfig | 1 -
> configs/rock-pi-e-rk3328_defconfig | 1 -
> configs/rock-pi-s-rk3308_defconfig | 1 -
> configs/sheep-rk3368_defconfig | 1 -
> 16 files changed, 16 deletions(-)
>
> diff --git a/configs/evb-px30_defconfig b/configs/evb-px30_defconfig
> index 4ac161683c..d75329d385 100644
> --- a/configs/evb-px30_defconfig
> +++ b/configs/evb-px30_defconfig
> @@ -100,7 +100,6 @@ CONFIG_DM_RNG=y
> CONFIG_RNG_ROCKCHIP=y
> # CONFIG_SPECIFY_CONSOLE_INDEX is not set
> CONFIG_DEBUG_UART_SHIFT=2
> -CONFIG_DEBUG_UART_SKIP_INIT=y
> CONFIG_SYS_NS16550_MEM32=y
> CONFIG_SOUND=y
> CONFIG_SYSRESET=y
> diff --git a/configs/evb-px5_defconfig b/configs/evb-px5_defconfig
> index 29f7516e75..5f32c92674 100644
> --- a/configs/evb-px5_defconfig
> +++ b/configs/evb-px5_defconfig
> @@ -76,7 +76,6 @@ CONFIG_RAM=y
> CONFIG_SPL_RAM=y
> CONFIG_TPL_RAM=y
> CONFIG_DEBUG_UART_SHIFT=2
> -CONFIG_DEBUG_UART_SKIP_INIT=y
> CONFIG_SYS_NS16550_MEM32=y
> CONFIG_SYSRESET=y
> CONFIG_PANIC_HANG=y
> diff --git a/configs/evb-rk3308_defconfig b/configs/evb-rk3308_defconfig
> index 6950b5ba06..a13a809c1e 100644
> --- a/configs/evb-rk3308_defconfig
> +++ b/configs/evb-rk3308_defconfig
> @@ -73,7 +73,6 @@ CONFIG_PWM_ROCKCHIP=y
> CONFIG_RAM=y
> CONFIG_BAUDRATE=1500000
> CONFIG_DEBUG_UART_SHIFT=2
> -CONFIG_DEBUG_UART_SKIP_INIT=y
> CONFIG_SYS_NS16550_MEM32=y
> CONFIG_SYSRESET=y
> CONFIG_USB=y
> diff --git a/configs/evb-rk3328_defconfig b/configs/evb-rk3328_defconfig
> index 580ee502dc..9bfb8f1df2 100644
> --- a/configs/evb-rk3328_defconfig
> +++ b/configs/evb-rk3328_defconfig
> @@ -87,7 +87,6 @@ CONFIG_TPL_RAM=y
> CONFIG_BAUDRATE=1500000
> CONFIG_DEBUG_UART_SHIFT=2
> CONFIG_DEBUG_UART_ANNOUNCE=y
> -CONFIG_DEBUG_UART_SKIP_INIT=y
> CONFIG_SYS_NS16550_MEM32=y
> CONFIG_SYSRESET=y
> # CONFIG_TPL_SYSRESET is not set
> diff --git a/configs/firefly-px30_defconfig b/configs/firefly-px30_defconfig
> index 47c924c3df..11a3baa7a3 100644
> --- a/configs/firefly-px30_defconfig
> +++ b/configs/firefly-px30_defconfig
> @@ -99,7 +99,6 @@ CONFIG_TPL_RAM=y
> CONFIG_ROCKCHIP_SDRAM_COMMON=y
> # CONFIG_SPECIFY_CONSOLE_INDEX is not set
> CONFIG_DEBUG_UART_SHIFT=2
> -CONFIG_DEBUG_UART_SKIP_INIT=y
> CONFIG_SYS_NS16550_MEM32=y
> CONFIG_SOUND=y
> CONFIG_SYSRESET=y
> diff --git a/configs/geekbox_defconfig b/configs/geekbox_defconfig
> index fdd01b6494..8f4be79831 100644
> --- a/configs/geekbox_defconfig
> +++ b/configs/geekbox_defconfig
> @@ -26,7 +26,6 @@ CONFIG_PINCTRL=y
> CONFIG_RAM=y
> CONFIG_DEBUG_UART_SHIFT=2
> CONFIG_DEBUG_UART_ANNOUNCE=y
> -CONFIG_DEBUG_UART_SKIP_INIT=y
> CONFIG_SYS_NS16550_MEM32=y
> CONFIG_SYSRESET=y
> CONFIG_ERRNO_STR=y
> diff --git a/configs/lion-rk3368_defconfig b/configs/lion-rk3368_defconfig
> index 2a180609b2..7c55b3be0d 100644
> --- a/configs/lion-rk3368_defconfig
> +++ b/configs/lion-rk3368_defconfig
> @@ -95,7 +95,6 @@ CONFIG_SPL_RAM=y
> CONFIG_TPL_RAM=y
> CONFIG_DEBUG_UART_SHIFT=2
> CONFIG_DEBUG_UART_ANNOUNCE=y
> -CONFIG_DEBUG_UART_SKIP_INIT=y
> CONFIG_SYS_NS16550_MEM32=y
> CONFIG_ROCKCHIP_SPI=y
> CONFIG_SYSINFO=y
> diff --git a/configs/odroid-go2_defconfig b/configs/odroid-go2_defconfig
> index 459ae3d59c..0a20a3011c 100644
> --- a/configs/odroid-go2_defconfig
> +++ b/configs/odroid-go2_defconfig
> @@ -103,7 +103,6 @@ CONFIG_TPL_RAM=y
> CONFIG_ROCKCHIP_SDRAM_COMMON=y
> # CONFIG_SPECIFY_CONSOLE_INDEX is not set
> CONFIG_DEBUG_UART_SHIFT=2
> -CONFIG_DEBUG_UART_SKIP_INIT=y
> CONFIG_SYS_NS16550_MEM32=y
> CONFIG_SOUND=y
> CONFIG_SYSRESET=y
> diff --git a/configs/px30-core-ctouch2-of10-px30_defconfig b/configs/px30-core-ctouch2-of10-px30_defconfig
> index abe6cfbd57..d96fd14b36 100644
> --- a/configs/px30-core-ctouch2-of10-px30_defconfig
> +++ b/configs/px30-core-ctouch2-of10-px30_defconfig
> @@ -99,7 +99,6 @@ CONFIG_DM_RNG=y
> CONFIG_RNG_ROCKCHIP=y
> # CONFIG_SPECIFY_CONSOLE_INDEX is not set
> CONFIG_DEBUG_UART_SHIFT=2
> -CONFIG_DEBUG_UART_SKIP_INIT=y
> CONFIG_SYS_NS16550_MEM32=y
> CONFIG_SOUND=y
> CONFIG_SYSRESET=y
> diff --git a/configs/px30-core-ctouch2-px30_defconfig b/configs/px30-core-ctouch2-px30_defconfig
> index e839dcb5f6..ac2af6d8cb 100644
> --- a/configs/px30-core-ctouch2-px30_defconfig
> +++ b/configs/px30-core-ctouch2-px30_defconfig
> @@ -99,7 +99,6 @@ CONFIG_DM_RNG=y
> CONFIG_RNG_ROCKCHIP=y
> # CONFIG_SPECIFY_CONSOLE_INDEX is not set
> CONFIG_DEBUG_UART_SHIFT=2
> -CONFIG_DEBUG_UART_SKIP_INIT=y
> CONFIG_SYS_NS16550_MEM32=y
> CONFIG_SOUND=y
> CONFIG_SYSRESET=y
> diff --git a/configs/px30-core-edimm2.2-px30_defconfig b/configs/px30-core-edimm2.2-px30_defconfig
> index 92540e73be..a49bb4072d 100644
> --- a/configs/px30-core-edimm2.2-px30_defconfig
> +++ b/configs/px30-core-edimm2.2-px30_defconfig
> @@ -99,7 +99,6 @@ CONFIG_DM_RNG=y
> CONFIG_RNG_ROCKCHIP=y
> # CONFIG_SPECIFY_CONSOLE_INDEX is not set
> CONFIG_DEBUG_UART_SHIFT=2
> -CONFIG_DEBUG_UART_SKIP_INIT=y
> CONFIG_SYS_NS16550_MEM32=y
> CONFIG_SOUND=y
> CONFIG_SYSRESET=y
> diff --git a/configs/ringneck-px30_defconfig b/configs/ringneck-px30_defconfig
> index e9234efc2a..cdec0c52e6 100644
> --- a/configs/ringneck-px30_defconfig
> +++ b/configs/ringneck-px30_defconfig
> @@ -111,7 +111,6 @@ CONFIG_DM_RNG=y
> CONFIG_RNG_ROCKCHIP=y
> # CONFIG_SPECIFY_CONSOLE_INDEX is not set
> CONFIG_DEBUG_UART_SHIFT=2
> -CONFIG_DEBUG_UART_SKIP_INIT=y
> CONFIG_SYS_NS16550_MEM32=y
> CONFIG_SOUND=y
> CONFIG_SYSRESET=y
> diff --git a/configs/roc-cc-rk3308_defconfig b/configs/roc-cc-rk3308_defconfig
> index 8eafd52a6b..9a789b212f 100644
> --- a/configs/roc-cc-rk3308_defconfig
> +++ b/configs/roc-cc-rk3308_defconfig
> @@ -73,7 +73,6 @@ CONFIG_PWM_ROCKCHIP=y
> CONFIG_RAM=y
> CONFIG_BAUDRATE=1500000
> CONFIG_DEBUG_UART_SHIFT=2
> -CONFIG_DEBUG_UART_SKIP_INIT=y
> CONFIG_SYS_NS16550_MEM32=y
> CONFIG_SYSRESET=y
> CONFIG_USB=y
> diff --git a/configs/rock-pi-e-rk3328_defconfig b/configs/rock-pi-e-rk3328_defconfig
> index 9c67d0c5fe..68357fed07 100644
> --- a/configs/rock-pi-e-rk3328_defconfig
> +++ b/configs/rock-pi-e-rk3328_defconfig
> @@ -95,7 +95,6 @@ CONFIG_TPL_RAM=y
> CONFIG_BAUDRATE=1500000
> CONFIG_DEBUG_UART_SHIFT=2
> CONFIG_DEBUG_UART_ANNOUNCE=y
> -CONFIG_DEBUG_UART_SKIP_INIT=y
> CONFIG_SYS_NS16550_MEM32=y
> CONFIG_SYSINFO=y
> CONFIG_SYSINFO_SMBIOS=y
> diff --git a/configs/rock-pi-s-rk3308_defconfig b/configs/rock-pi-s-rk3308_defconfig
> index d306b58b8e..cc3274a98b 100644
> --- a/configs/rock-pi-s-rk3308_defconfig
> +++ b/configs/rock-pi-s-rk3308_defconfig
> @@ -74,7 +74,6 @@ CONFIG_PWM_ROCKCHIP=y
> CONFIG_RAM=y
> CONFIG_BAUDRATE=1500000
> CONFIG_DEBUG_UART_SHIFT=2
> -CONFIG_DEBUG_UART_SKIP_INIT=y
> CONFIG_SYS_NS16550_MEM32=y
> CONFIG_SYSRESET=y
> CONFIG_USB=y
> diff --git a/configs/sheep-rk3368_defconfig b/configs/sheep-rk3368_defconfig
> index 044e1060a5..a591b2741d 100644
> --- a/configs/sheep-rk3368_defconfig
> +++ b/configs/sheep-rk3368_defconfig
> @@ -28,7 +28,6 @@ CONFIG_PINCTRL=y
> CONFIG_RAM=y
> CONFIG_DEBUG_UART_SHIFT=2
> CONFIG_DEBUG_UART_ANNOUNCE=y
> -CONFIG_DEBUG_UART_SKIP_INIT=y
> CONFIG_SYS_NS16550_MEM32=y
> CONFIG_SYSRESET=y
> CONFIG_ERRNO_STR=y
More information about the U-Boot
mailing list