[PATCH v3 0/3] board: rockchip: Add Hardkernel ODROID-M1

Jonas Karlman jonas at kwiboo.se
Wed Jul 26 08:34:37 CEST 2023


Hi Tom,

On 2023-07-26 03:47, Kever Yang wrote:
> Hi Jonas,
> 
>      Could you split this patchset into two patch set?
> 
>      I can take the patch 3, but the patch 1~2 is suppose to go to other 
> maintainer's tree, unless those patches got ACK from maintainer.

No one is listed as maintainer for these files when using get_maintainer.pl,
who can/should ACK these trivial compile fixes?

For patch 1811288 related to compile error in drivers/ata/dwc_ahci.c:

  $ scripts/get_maintainer.pl -f drivers/ata/dwc_ahci.c
  Jonas Karlman <jonas at kwiboo.se> (commit_signer:1/1=100%,authored:1/1=100%,added_lines:4/4=100%)
  u-boot at lists.denx.de (open list)

For patch 1811290 related to compile warning in cmd/ini.c:

  $ scripts/get_maintainer.pl -f cmd/ini.c
  Jonas Karlman <jonas at kwiboo.se> (commit_signer:1/1=100%,authored:1/1=100%,added_lines:1/1=100%,removed_lines:1/1=100%)
  u-boot at lists.denx.de (open list)

Regards,
Jonas

> 
> 
> Thanks,
> 
>   - Kever
> 
> On 2023/7/22 22:02, Jonas Karlman wrote:
>> This series add support for Hardkernel ODROID-M1, a single board
>> computer with a RK3568B2 SoC.
>>
>> First patch fixes a build issue in the dwc_ahci driver.
>>
>> Second patch fixes a build warning in the ini command.
>>
>> Third patch import the device tree from linux v6.4 and add a defconfig
>> for Hardkernel ODROID-M1.
>>
>> Following was tested on a ODROID-M1 8GB v1.0 2022-06-13:
>> - SD-card boot
>> - eMMC boot
>> - SPI Flash boot
>> - PCIe/NVMe/AHCI
>> - SATA port
>> - USB host
>>
>> Changes in v3:
>> - Remove vcc5v0_usb_host regulator-always-on workaround
>> - Remove CONFIG_ETH_DESIGNWARE=y and CONFIG_GMAC_ROCKCHIP=y
>>
>> Changes in v2:
>> - Add new patch to fix build warning in the ini command
>> - Enable CMD_MTD, CMD_INI and CMD_CRAMFS to closer
>>    match downstream legacy U-Boot
>> - Do not override spi0 alias, use SF_DEFAULT_BUS=4
>> - Collect r-b and t-b tags
>>
>> With the new options added in v2 it is possible to load downstream
>> petitboot from SD-card using following commands:
>>
>>    load mmc 1:1 $fdt_addr_r rk3568-odroid-m1.dtb
>>    load mmc 1:1 $cramfsaddr ODROIDBIOS.BIN
>>    cramfsload $scriptaddr boot.scr
>>    source $scriptaddr
>>
>> This series have loose dependencies on the following series:
>> - rockchip: Fix PCIe and NVMe support on RK3568 [1]
>> - rockchip: rk3568: Use dwc3-generic driver [2]
>> - rockchip: rk3568: Fix alloc space exhausted in SPL [3]
>> - rockchip: rk3568: Device Tree updates [4]
>> - rockchip: rk35xx: Fix SPI Flash alias [5]
>>
>> [1] https://patchwork.ozlabs.org/project/uboot/list/?series=365195
>> [2] https://patchwork.ozlabs.org/project/uboot/list/?series=364127
>> [3] https://patchwork.ozlabs.org/project/uboot/list/?series=361999
>> [4] https://patchwork.ozlabs.org/project/uboot/list/?series=362030
>> [5] https://patchwork.ozlabs.org/project/uboot/list/?series=363527
>>
>> Jonas Karlman (3):
>>    ata: dwc_ahci: Fix support for other platforms
>>    cmd: ini: Fix build warning
>>    board: rockchip: Add Hardkernel ODROID-M1
>>
>>   arch/arm/dts/Makefile                     |   1 +
>>   arch/arm/dts/rk3568-odroid-m1-u-boot.dtsi |  37 ++
>>   arch/arm/dts/rk3568-odroid-m1.dts         | 744 ++++++++++++++++++++++
>>   arch/arm/mach-rockchip/rk3568/Kconfig     |   6 +
>>   board/hardkernel/odroid_m1/Kconfig        |  15 +
>>   board/hardkernel/odroid_m1/MAINTAINERS    |   8 +
>>   board/hardkernel/odroid_m1/Makefile       |   3 +
>>   board/hardkernel/odroid_m1/odroid_m1.c    |   1 +
>>   cmd/ini.c                                 |   2 +-
>>   configs/odroid-m1-rk3568_defconfig        | 111 ++++
>>   doc/board/rockchip/rockchip.rst           |   1 +
>>   drivers/ata/dwc_ahci.c                    |   4 +
>>   include/configs/odroid_m1.h               |  11 +
>>   13 files changed, 943 insertions(+), 1 deletion(-)
>>   create mode 100644 arch/arm/dts/rk3568-odroid-m1-u-boot.dtsi
>>   create mode 100644 arch/arm/dts/rk3568-odroid-m1.dts
>>   create mode 100644 board/hardkernel/odroid_m1/Kconfig
>>   create mode 100644 board/hardkernel/odroid_m1/MAINTAINERS
>>   create mode 100644 board/hardkernel/odroid_m1/Makefile
>>   create mode 100644 board/hardkernel/odroid_m1/odroid_m1.c
>>   create mode 100644 configs/odroid-m1-rk3568_defconfig
>>   create mode 100644 include/configs/odroid_m1.h
>>



More information about the U-Boot mailing list