[PATCH v2 01/12] scmi: refactor the code to hide a channel from devices

Simon Glass sjg at chromium.org
Thu Jul 27 02:50:19 CEST 2023


On Wed, 26 Jul 2023 at 02:38, AKASHI Takahiro
<takahiro.akashi at linaro.org> wrote:
>
> The commit 85dc58289238 ("firmware: scmi: prepare uclass to pass channel
> reference") added an explicit parameter, channel, but it seems to make
> the code complex.
>
> Hiding this parameter will allow for adding a generic (protocol-agnostic)
> helper function, i.e. for PROTOCOL_VERSION, in a later patch.
>
> Signed-off-by: AKASHI Takahiro <takahiro.akashi at linaro.org>
> ---
> v2
> * new patch
> ---
>  drivers/clk/clk_scmi.c                    | 27 ++-------
>  drivers/firmware/scmi/scmi_agent-uclass.c | 74 ++++++++++++++++++-----
>  drivers/power/regulator/scmi_regulator.c  | 27 +++------
>  drivers/reset/reset-scmi.c                | 19 +-----
>  include/scmi_agent.h                      | 15 +++--
>  5 files changed, 86 insertions(+), 76 deletions(-)
>

Reviewed-by: Simon Glass <sjg at chromium.org>


More information about the U-Boot mailing list