[PATCH 2/9] video: Tidy up Makefile rule for video

Simon Glass sjg at chromium.org
Fri Jul 28 19:32:42 CEST 2023


Hi Bin,

On Fri, 28 Jul 2023 at 09:46, Bin Meng <bmeng.cn at gmail.com> wrote:
>
> Hi Simon,
>
> On Mon, Jul 24, 2023 at 10:52 PM Simon Glass <sjg at chromium.org> wrote:
> >
> > Drop the duplication and add a single rule which can handle SPL as well.
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
> > ---
> >
> >  drivers/Makefile | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/Makefile b/drivers/Makefile
> > index 3bc6d279d7cb..7272681fc741 100644
> > --- a/drivers/Makefile
> > +++ b/drivers/Makefile
> > @@ -39,6 +39,8 @@ obj-$(CONFIG_$(SPL_TPL_)TPM) += tpm/
> >  obj-$(CONFIG_$(SPL_)NVME) += nvme/
> >  obj-$(CONFIG_XEN) += xen/
> >  obj-$(CONFIG_$(SPL_)FPGA) += fpga/
> > +obj-$(CONFIG_$(SPL_TPL_)VIDEO) += video/
>
> This should be $(SPL_) as the original codes do not enable video build for TPL

Yes, but SPL_TPL supports that, in that TPL_VIDEO is not enabled, so
it will not be built for TPL. In general, we never need the $(SPL)
variant.

Regards,
Simon


More information about the U-Boot mailing list