Strange construct in binman description

[Tim Harvey]

On Wed, Jul 26, 2023, 5:55 PM Simon Glass <sjg at chromium.org> wrote:

> Hi Tim,
>
> On Mon, 24 Jul 2023 at 08:53, Simon Glass <sjg at chromium.org> wrote:
> >
> > Hi,
> >
> > On Sun, 23 Jul 2023 at 03:00, Marcel Ziswiler
> > <marcel.ziswiler at toradex.com> wrote:
> > >
> > > Hi Simon
> > >
> > > On Jul 23, 2023 05:48, Simon Glass <sjg at chromium.org> wrote:
> > >
> > > Hi Marcel,
> > >
> > > I just noticed this in an imx8 description:
> > >
> > > binman_configuration: @config-SEQ {
> > >
> > >
> > > I remember having stumbled over this before but I do not remember any
> exact details, sorry.
> > >
> > > Since this is a generator node, binman blindly generates a phandle for
> > > each not it generates. This means that if there is more than one
> > > config node, then they will have duplicate phandles.
> > >
> > > I have sent a series to correct this, but it fails the build on:
> > > imx8mm_venice imx8mn_venice imx8mp_venice
> > >
> > >
> > > Ah, now I get it. You mixed up venice (Gate works) with verdin
> (Toradex).
> > >
> > > I am a bit unsure about what this is supposed to do. Could you please
> > > take a look?
> > >
> > >
> > > I'm more than happy to do that but you are probably much better off
> enquiring Tim Harvey from Gateworks about this. I put him on CC.
> >
> > Tim, any thoughts on this please?
>
> Can you please weigh in on this one?
>

Simon,

I'm away from a computer until next week.

Can you point me to the series in reference here?

The -seq is for configs that support multiple dtbs which the Venice configs
use.

Best regards,

Tim


> Regards,
> Simon
>