[PATCH 1/1] efi_loader: catch out of memory in file_open

Ilias Apalodimas ilias.apalodimas at linaro.org
Mon Jul 31 10:08:27 CEST 2023


On Sun, 30 Jul 2023 at 15:07, Heinrich Schuchardt
<heinrich.schuchardt at canonical.com> wrote:
>
> If calloc() return NULL, don't dereference it.
>
> Fixes: 2a92080d8c44 ("efi_loader: add file/filesys support")
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
> ---
>  lib/efi_loader/efi_file.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/lib/efi_loader/efi_file.c b/lib/efi_loader/efi_file.c
> index 3764a92b50..3c56cebf96 100644
> --- a/lib/efi_loader/efi_file.c
> +++ b/lib/efi_loader/efi_file.c
> @@ -195,6 +195,8 @@ static struct efi_file_handle *file_open(struct file_system *fs,
>
>         /* +2 is for null and '/' */
>         fh = calloc(1, sizeof(*fh) + plen + (flen * MAX_UTF8_PER_UTF16) + 2);
> +       if (!fh)
> +               return NULL;
>
>         fh->open_mode = open_mode;
>         fh->base = efi_file_handle_protocol;
> --
> 2.40.1
>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas at linaro.org>


More information about the U-Boot mailing list