[PATCH v3 1/4] cmd: bind: Add unbind command with driver filter

Marek Vasut marex at denx.de
Mon Jul 31 13:44:25 CEST 2023


On 7/31/23 11:31, Miquel Raynal wrote:
> Hi Marek,
> 
> marex at denx.de wrote on Sat, 29 Jul 2023 16:57:09 +0200:
> 
>> Extend the driver core to perform lookup by both OF node and driver
>> bound to the node. Use this to look up specific device instances to
>> unbind from nodes in the unbind command. One example where this is
>> needed is USB peripheral controller, which may have multiple gadget
>> drivers bound to it. The unbind command has to select that specific
>> gadget driver instance to unbind from the controller, not unbind the
>> controller driver itself from the controller.
>>
>> USB ethernet gadget usage looks as follows with this change. Notice
>> the extra 'usb_ether' addition in the 'unbind' command at the end.
>> "
>> bind /soc/usb-otg at 49000000 usb_ether
>> setenv ethact usb_ether
>> setenv loadaddr 0xc2000000
>> setenv ipaddr 10.0.0.2
>> setenv serverip 10.0.0.1
>> setenv netmask 255.255.255.0
>> tftpboot 0xc2000000 10.0.0.1:test.file
>> unbind /soc/usb-otg at 49000000 usb_ether
>> "
>>
>> Signed-off-by: Marek Vasut <marex at denx.de>
>> ---
> 
> I am no longer getting wrong pointer dereferences, the SPL is working in
> recovery mode, TFTP "File not found" errors are no longer a problem and
> I did not experience any reset while tftp'ing regular files.
> 
> One last remaining request on my side is the need for using fastboot as
> well which does no longer work as-is:
> 
> => fastboot usb 0
> couldn't find an available UDC
> g_dnl_register: failed!, error: -19
> exit not allowed from main input shell.
> 
> Can you advise what bind/unbind command would be necessary here?

Either 'unbind usb_ether' or run 'dm tree' -> look up the path to 
usb_ether in the tree (it will be hanging under usb_peripheral or some 
such), and then use 'unbind <that path>'.


More information about the U-Boot mailing list