[PATCH 07/14] net: sunxi_emac: Switch to new U-Boot PHY API

Ramon Fried rfried.dev at gmail.com
Sat Jun 10 13:00:25 CEST 2023


On Wed, May 31, 2023 at 1:51 AM Marek Vasut
<marek.vasut+renesas at mailbox.org> wrote:
>
> Use new U-Boot phy_connect() API which also supports fixed PHYs.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas at mailbox.org>
> ---
> Cc: Geert Uytterhoeven <geert+renesas at glider.be>
> Cc: Joe Hershberger <joe.hershberger at ni.com>
> Cc: Michal Simek <michal.simek at amd.com>
> Cc: Nishanth Menon <nm at ti.com>
> Cc: Ramon Fried <rfried.dev at gmail.com>
> ---
>  drivers/net/sunxi_emac.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/sunxi_emac.c b/drivers/net/sunxi_emac.c
> index ad9e1abd161..4c90d4b4981 100644
> --- a/drivers/net/sunxi_emac.c
> +++ b/drivers/net/sunxi_emac.c
> @@ -248,10 +248,10 @@ static int emac_mdio_write(struct mii_dev *bus, int addr, int devad, int reg,
>
>  static int sunxi_emac_init_phy(struct emac_eth_dev *priv, void *dev)
>  {
> -       int ret, mask = 0xffffffff;
> +       int ret, mask = -1;
>
>  #ifdef CONFIG_PHY_ADDR
> -       mask = 1 << CONFIG_PHY_ADDR;
> +       mask = CONFIG_PHY_ADDR;
>  #endif
>
>         priv->bus = mdio_alloc();
> @@ -269,11 +269,10 @@ static int sunxi_emac_init_phy(struct emac_eth_dev *priv, void *dev)
>         if (ret)
>                 return ret;
>
> -       priv->phydev = phy_find_by_mask(priv->bus, mask);
> +       priv->phydev = phy_connect(priv->bus, mask, dev, PHY_INTERFACE_MODE_MII);
>         if (!priv->phydev)
>                 return -ENODEV;
>
> -       phy_connect_dev(priv->phydev, dev, PHY_INTERFACE_MODE_MII);
>         phy_config(priv->phydev);
>
>         return 0;
> --
> 2.39.2
>
Reviewed-by: Ramon Fried <rfried.dev at gmail.com>


More information about the U-Boot mailing list