[PATCH 08/14] net: phy: Unpublish phy_connect_dev()

Ramon Fried rfried.dev at gmail.com
Sat Jun 10 13:00:32 CEST 2023


On Wed, May 31, 2023 at 1:51 AM Marek Vasut
<marek.vasut+renesas at mailbox.org> wrote:
>
> The phy_connect_dev() is legacy API, now that there are no users,
> make it internal to phy.c and unpublish it from headers.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas at mailbox.org>
> ---
> Cc: Geert Uytterhoeven <geert+renesas at glider.be>
> Cc: Joe Hershberger <joe.hershberger at ni.com>
> Cc: Michal Simek <michal.simek at amd.com>
> Cc: Nishanth Menon <nm at ti.com>
> Cc: Ramon Fried <rfried.dev at gmail.com>
> ---
>  drivers/net/phy/phy.c | 4 ++--
>  include/phy.h         | 9 ---------
>  2 files changed, 2 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
> index 0eeb0cb3a85..ae21acb059b 100644
> --- a/drivers/net/phy/phy.c
> +++ b/drivers/net/phy/phy.c
> @@ -812,8 +812,8 @@ struct phy_device *phy_find_by_mask(struct mii_dev *bus, uint phy_mask)
>         return get_phy_device_by_mask(bus, phy_mask);
>  }
>
> -void phy_connect_dev(struct phy_device *phydev, struct udevice *dev,
> -                    phy_interface_t interface)
> +static void phy_connect_dev(struct phy_device *phydev, struct udevice *dev,
> +                           phy_interface_t interface)
>  {
>         /* Soft Reset the PHY */
>         phy_reset(phydev);
> diff --git a/include/phy.h b/include/phy.h
> index 247223d92be..f023a3c2685 100644
> --- a/include/phy.h
> +++ b/include/phy.h
> @@ -223,15 +223,6 @@ static inline struct phy_device *fixed_phy_create(ofnode node)
>
>  #endif
>
> -/**
> - * phy_connect_dev() - Associates the given pair of PHY and Ethernet devices
> - * @phydev:    PHY device
> - * @dev:       Ethernet device
> - * @interface: type of MAC-PHY interface
> - */
> -void phy_connect_dev(struct phy_device *phydev, struct udevice *dev,
> -                    phy_interface_t interface);
> -
>  /**
>   * phy_connect() - Creates a PHY device for the Ethernet interface
>   * Creates a PHY device for the PHY at the given address, if one doesn't exist
> --
> 2.39.2
>
Reviewed-by: Ramon Fried <rfried.dev at gmail.com>


More information about the U-Boot mailing list