[PATCH 03/32] cmd: fdt: Fix fdt rm behavior on non-existent property and error message space

Simon Glass sjg at chromium.org
Wed Mar 1 16:01:59 CET 2023


On Mon, 27 Feb 2023 at 12:55, Marek Vasut
<marek.vasut+renesas at mailbox.org> wrote:
>
> In case an FDT contains a node '/test-node at 1234' , with no property
> called 'noprop' in that node, the following command triggers a print
> of help message for 'fdt' command instead of erroring out:
> => fdt rm /test-node at 1234 noprop
> This is because the subcommand errornously returns 'err' instead of
> CMD_RET_FAILURE, fix it. Furthermore, align the number of spaces past
> fdt_delprop() in error message with the rest of the code.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas at mailbox.org>
> ---
> Cc: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
> Cc: Simon Glass <sjg at chromium.org>
> Cc: Tom Rini <trini at konsulko.com>
> ---
>  cmd/fdt.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Simon Glass <sjg at chromium.org>


More information about the U-Boot mailing list