[PATCH 04/32] cmd: fdt: Fix fdt rsvmem behavior on non-existent index and error message space

Simon Glass sjg at chromium.org
Wed Mar 1 16:02:00 CET 2023


On Mon, 27 Feb 2023 at 12:55, Marek Vasut
<marek.vasut+renesas at mailbox.org> wrote:
>
> In case 'fdt rsvmem delete index' is passed a non-existent index, one
> which does not exist in 'fdt rsvmem print', then the following command
> triggers a print of help message for 'fdt' command instead of erroring
> out:
> => fdt rsvmem delete 1234
> This is because the subcommand errornously returns 'err' instead of
> CMD_RET_FAILURE, fix it. Furthermore, align the number of spaces past
> fdt_del_mem_rsv() and fdt_add_mem_rsv() in error message with the rest
> of the code.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas at mailbox.org>
> ---
> Cc: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
> Cc: Simon Glass <sjg at chromium.org>
> Cc: Tom Rini <trini at konsulko.com>
> ---
>  cmd/fdt.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>

Reviewed-by: Simon Glass <sjg at chromium.org>


More information about the U-Boot mailing list