[PATCH v1 7/7] arm: dts: rockchip: rk3288: partial sync pwm nodes

Simon Glass sjg at chromium.org
Wed Mar 15 15:05:46 CET 2023


Hi Johan,

On Tue, 14 Mar 2023 at 12:16, Johan Jonker <jbx6244 at gmail.com> wrote:
>
> In order to better compare the Linux rk3288.dtsi
> version 6.3 -rc2 with the u-boot version partial
> sync the pwm nodes.
>
> Signed-off-by: Johan Jonker <jbx6244 at gmail.com>
> ---
>  arch/arm/dts/rk3288.dtsi | 18 +++++-------------
>  1 file changed, 5 insertions(+), 13 deletions(-)
>
> diff --git a/arch/arm/dts/rk3288.dtsi b/arch/arm/dts/rk3288.dtsi
> index f24e9ba5..dd1d9897 100644
> --- a/arch/arm/dts/rk3288.dtsi
> +++ b/arch/arm/dts/rk3288.dtsi
> @@ -675,9 +675,7 @@
>                 #pwm-cells = <3>;
>                 pinctrl-names = "default";
>                 pinctrl-0 = <&pwm0_pin>;
> -               clocks = <&cru PCLK_PWM>;
> -               clock-names = "pwm";
> -               rockchip,grf = <&grf>;
> +               clocks = <&cru PCLK_RKPWM>;
>                 status = "disabled";
>         };
>
> @@ -687,9 +685,7 @@
>                 #pwm-cells = <3>;
>                 pinctrl-names = "default";
>                 pinctrl-0 = <&pwm1_pin>;
> -               clocks = <&cru PCLK_PWM>;
> -               clock-names = "pwm";
> -               rockchip,grf = <&grf>;
> +               clocks = <&cru PCLK_RKPWM>;
>                 status = "disabled";
>         };
>
> @@ -699,21 +695,17 @@
>                 #pwm-cells = <3>;
>                 pinctrl-names = "default";
>                 pinctrl-0 = <&pwm2_pin>;
> -               clocks = <&cru PCLK_PWM>;
> -               clock-names = "pwm";
> -               rockchip,grf = <&grf>;
> +               clocks = <&cru PCLK_RKPWM>;
>                 status = "disabled";
>         };
>
>         pwm3: pwm at ff680030 {
>                 compatible = "rockchip,rk3288-pwm";
>                 reg = <0xff680030 0x10>;
> -               #pwm-cells = <2>;
> +               #pwm-cells = <3>;

How can we do this without breaking the existing pwm usage in U-Boot?

>                 pinctrl-names = "default";
>                 pinctrl-0 = <&pwm3_pin>;
> -               clocks = <&cru PCLK_PWM>;
> -               clock-names = "pwm";
> -               rockchip,grf = <&grf>;
> +               clocks = <&cru PCLK_RKPWM>;
>                 status = "disabled";
>         };
>
> --
> 2.20.1
>

Regards,
Simon


More information about the U-Boot mailing list