[PATCH] net: phy: Request rgmii-id phy reset gpio as output

Michal Simek michal.simek at amd.com
Wed May 3 15:50:18 CEST 2023



On 5/2/23 14:50, Stefan Herbrechtsmeier wrote:
> From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier at weidmueller.com>
> 
> Request the reset gpio of the rgmii-id phy as output to be consistent
> with the eth-phy-uclass driver.
> 
> Signed-off-by: Stefan Herbrechtsmeier <stefan.herbrechtsmeier at weidmueller.com>
> ---
> 
>   drivers/net/phy/ethernet_id.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/phy/ethernet_id.c b/drivers/net/phy/ethernet_id.c
> index 8864f99bb3..a715e83db9 100644
> --- a/drivers/net/phy/ethernet_id.c
> +++ b/drivers/net/phy/ethernet_id.c
> @@ -39,7 +39,7 @@ struct phy_device *phy_connect_phy_id(struct mii_dev *bus, struct udevice *dev,
>   
>   	if (!IS_ENABLED(CONFIG_DM_ETH_PHY)) {
>   		ret = gpio_request_by_name_nodev(node, "reset-gpios", 0, &gpio,
> -						 GPIOD_ACTIVE_LOW);
> +						 GPIOD_IS_OUT | GPIOD_ACTIVE_LOW);
>   		if (!ret) {
>   			assert = ofnode_read_u32_default(node,
>   							 "reset-assert-us", 0);

Reviewed-by: Michal Simek <michal.simek at amd.com>

M


More information about the U-Boot mailing list