[PATCH 1/1] pico-imx7d: add baseboard SD card boot detect

[Fabio Estevam]

Hi Benjamin,

You should have indicated that this is v7.

The subject should be:

[PATCH v7] pico-imx7d: add baseboard SD card boot detect

No need for adding 1/1 for a single patch.

On Tue, Nov 7, 2023 at 7:16 PM <egyszeregy at freemail.hu> wrote:
>
> From: Benjamin Szőke <egyszeregy at freemail.hu>
>
> Technexion PICO-IMX7 SoM is supporting USDHC3 (eMMC or micro SD on SoM)
> and USDHC1 (SD on carrier board) to use on any carrier board like
> PICO-NYMPH. Based on the U-Boot version from Technexion it adds
> baseboard SD card boot detect to able to boot from selected USDHC1
> or USDHC3 boot devices.
>
>     - Add baseboard SD card boot detect from Technexion's U-Boot.
>     - Implement board_mmc_get_env_dev() for pico-imx7d SoM.
>     - Implement mmc_map_to_kernel_blk() for pico-imx7d SoM.
>     - Add board_late_mmc_env_init() to use from common freescale
>       functions to able to provide "mmcdev" and "mmcroot" variables
>       in environment of U-boot.
>     - Add "mmc1" alias to use for usdhc1 in imx7d-pico-pi-u-boot.dtsi.
>     - In default environment set "mmcautodetect=yes" to use boot detection.

These comments above should be placed below the --- line.

> Signed-off-by: Benjamin Szőke <egyszeregy at freemail.hu>
> ---

Here you should place the changelog:

Changes since v6:
- bla bla bla

> +#if CONFIG_IS_ENABLED(FSL_ESDHC_IMX)
> +#if CONFIG_IS_ENABLED(ENV_IS_IN_MMC) || CONFIG_IS_ENABLED(ENV_IS_NOWHERE)
> +int board_mmc_get_env_dev(int devno)
> +{
> +       int dev_env = 0;
> +       (void)(devno);

Why? Just drop this ' (void)(devno);' line.

I tested it successfully, so:

Tested-by: Fabio Estevam <festevam at gmail.com>