[PATCH 1/1] pico-imx7d: add baseboard SD card boot detect

[Szőke Kálmán Benjamin]

Hi,All previouse stage/patches was a "blind alley" solution because finally i found, many code parts are ready from freesacle sources. So needed to refactor the full codes, which seems now a totally new code/solution for it.So, I don't see the point in describing them in a changelog, useless to share logs about crappy attempts. Also i do not know how can be the git configured to use custom PATCH prefix, it was generated by git automatically.(void)(devno); is need because devno arguments is an unused variable, need to use this solution to suppress any potential warnings.I am ready with this patch, i will not change anything, i am done. If you feel something is missing in the descriptions or in code feel free to change it in text of my patch source or in a new patch, you can do it, if you are a maintainer. Now it's your turn to finalize it if something need more.-------- Eredeti levél --------Feladó: Fabio Estevam <festevam at gmail.com>Dátum: 2023 november 15 18:31:21Tárgy: Re: [PATCH 1/1] pico-imx7d: add baseboard SD card boot detectCímzett: egyszeregy at freemail.huHi Benjamin,  You should have indicated that this is v7.  The subject should be:  [PATCH v7] pico-imx7d: add baseboard SD card boot detect  No need for adding 1/1 for a single patch.  On Tue, Nov 7, 2023 at 7:16 PM <egyszeregy at freemail.hu> wrote: > > From: Benjamin Szőke <egyszeregy at freemail.hu> > > Technexion PICO-IMX7 SoM is supporting USDHC3 (eMMC or micro SD on SoM) > and USDHC1 (SD on carrier board) to use on any carrier board like > PICO-NYMPH. Based on the U-Boot version from Technexion it adds > baseboard SD card boot detect to able to boot from selected USDHC1 > or USDHC3 boot devices. > >     - Add baseboard SD card boot detect from Technexion's U-Boot. >     - Implement board_mmc_get_env_dev() for pico-imx7d SoM. >     - Implement mmc_map_to_kernel_blk() for pico-imx7d SoM. >     - Add board_late_mmc_env_init() to use from common freescale >       functions to able to provide "mmcdev" and "mmcroot" variables >       in environment of U-boot. >     - Add "mmc1" alias to use for usdhc1 in imx7d-pico-pi-u-boot.dtsi. >     - In default environment set "mmcautodetect=yes" to use boot detection.  These comments above should be placed below the --- line.  > Signed-off-by: Benjamin Szőke <egyszeregy at freemail.hu> > ---  Here you should place the changelog:  Changes since v6: - bla bla bla  > +#if CONFIG_IS_ENABLED(FSL_ESDHC_IMX) > +#if CONFIG_IS_ENABLED(ENV_IS_IN_MMC) || CONFIG_IS_ENABLED(ENV_IS_NOWHERE) > +int board_mmc_get_env_dev(int devno) > +{ > +       int dev_env = 0; > +       (void)(devno);  Why? Just drop this ' (void)(devno);' line.  I tested it successfully, so:  Tested-by: Fabio Estevam <festevam at gmail.com>