[PATCH 1/1] pico-imx7d: add baseboard SD card boot detect

Fabio Estevam festevam at gmail.com
Mon Nov 27 01:44:01 CET 2023


Hi Benjamin,

On Sun, Nov 26, 2023 at 8:17 PM Szőke Kálmán Benjamin
<egyszeregy at freemail.hu> wrote:
>
> It can happen when will -Wall be enabled as in others SW projects. My patches are final, ready and works. I will not remove this "supression", it must be a part of it if the target is to provide code in good quality. If you have any further whishes you can edit my patch and you can be a co-author.

Sorry, but this makes no sense.

You are going in the opposite direction of good code quality.

Both U-Boot and kernel pass -Wno-unused-parameter.

It is common to write codes for stub functions like this:

https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/include/linux/regulator/of_regulator.h?h=v6.6.2#n29

No (void)parameter is passed as you did in your patch. Like I said, it
is unnecessary.


More information about the U-Boot mailing list