[PATCH 1/1] pico-imx7d: add baseboard SD card boot detect

[Szőke Kálmán Benjamin]

Unused function parameters should be removedhttps://rules.sonarsource.com/c/tag/based-on-misra/RSPEC-1172/Quaility means the full SW has no any functions with unused paramteres. Unfortunatelly it seems u-boot and kernel source code are not best, it is time to improve it. You can see, i did it, so if you do not like it and you would like to keep the bad and historical solution you can change it in my patch yourself as a maintaner. I am not planning to submit any new patch version and my patch is done in my point of view.-------- Eredeti levél --------Feladó: Fabio Estevam <festevam at gmail.com>Dátum: 2023 november 27 01:44:16Tárgy: Re: [PATCH 1/1] pico-imx7d: add baseboard SD card boot detectCímzett: Szőke Kálmán Benjamin <egyszeregy at freemail.hu>Hi Benjamin,  On Sun, Nov 26, 2023 at 8:17 PM Szőke Kálmán Benjamin <egyszeregy at freemail.hu> wrote: > > It can happen when will -Wall be enabled as in others SW projects. My patches are final, ready and works. I will not remove this "supression", it must be a part of it if the target is to provide code in good quality. If you have any further whishes you can edit my patch and you can be a co-author.  Sorry, but this makes no sense.  You are going in the opposite direction of good code quality.  Both U-Boot and kernel pass -Wno-unused-parameter.  It is common to write codes for stub functions like this:  https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/include/linux/regulator/of_regulator.h?h=v6.6.2#n29  No (void)parameter is passed as you did in your patch. Like I said, it is unnecessary.