[REGRESSION] imx: spl_imx_romapi: boot loops

[Marcel Ziswiler]

Hi

On our weekly master upstream CI build we noticed Verdin iMX8M Plus boot looping.

Bisecting pointed to the following commit:

commit 4b4472438f5a ("imx: spl_imx_romapi: avoid tricky use of spl_load_simple_fit() to get full FIT size")

It looks like this introduced a regression.

Before and after console output (with DEBUG defined in arch/arm/mach-imx/spl_imx_romapi.c) below:

Any comments?

Cheers

Marcel


Before:

U-Boot SPL 2023.10-00969-g9960d4a5402-dirty (Oct 24 2023 - 09:20:03 +0200)
Training FAILED
DDR configured as single rank
SEC0:  RNG instantiated
Normal Boot
WDT:   Started watchdog at 30280000 with servicing every 1000ms (60s timeout)
Trying to boot from BOOTROM
Boot Stage: Primary boot
Find img info 0x4802b000, size 1044
Need continue download 1024
Download 932864, Total size 934544
NOTICE:  Do not release JR0 to NS as it can be used by HAB
NOTICE:  BL31: v2.9(release):v2.9.0-619-g5f01b0b11
NOTICE:  BL31: Built : 11:08:02, Sep  6 2023


U-Boot 2023.10-00969-g9960d4a5402-dirty (Oct 24 2023 - 09:20:03 +0200)

CPU:   Freescale i.MX8MP[8] rev1.1 1600 MHz (running at 1200 MHz)
[snip]


After (e.g. commit 4b4472438f5 or master):

U-Boot SPL 2024.01-rc1-dirty (Oct 24 2023 - 09:28:26 +0200)
Training FAILED
DDR configured as single rank
SEC0:  RNG instantiated
Normal Boot
WDT:   Started watchdog at 30280000 with servicing every 1000ms (60s timeout)
Trying to boot from BOOTROM
Boot Stage: Primary boot
Find img info 0x4802b000, size 1044
Need continue download 1024
downloading another 0xc9000 bytes
downloading another 0x1ae00 bytes

=> this crash/resets and boot loops forever