[REGRESSION] imx: spl_imx_romapi: boot loops

[Rasmus Villemoes]

On 24/10/2023 09.39, Marcel Ziswiler wrote:
> Hi
> 
> On our weekly master upstream CI build we noticed Verdin iMX8M Plus boot looping.
> 
> Bisecting pointed to the following commit:
> 
> commit 4b4472438f5a ("imx: spl_imx_romapi: avoid tricky use of spl_load_simple_fit() to get full FIT size")
> 
> It looks like this introduced a regression.
> 
> Before and after console output (with DEBUG defined in arch/arm/mach-imx/spl_imx_romapi.c) below:
> 
> 
> After (e.g. commit 4b4472438f5 or master):
> 
> U-Boot SPL 2024.01-rc1-dirty (Oct 24 2023 - 09:28:26 +0200)
> Training FAILED
> DDR configured as single rank
> SEC0:  RNG instantiated
> Normal Boot
> WDT:   Started watchdog at 30280000 with servicing every 1000ms (60s timeout)
> Trying to boot from BOOTROM
> Boot Stage: Primary boot
> Find img info 0x4802b000, size 1044
> Need continue download 1024
> downloading another 0xc9000 bytes
> downloading another 0x1ae00 bytes

Hm. Can you show the result of 'fdtdump u-boot.itb | head' as well as
just the actual file sizes of u-boot.itb and flash.bin.

Also, in spl_romapi_read_stream(), can you add a print out what
ss->pagesize is, and also an unconditional printf() after the
rom_api_download_image() - we apparently don't hit the "Failure download
%d", but I'd still like to see if we even return from that
rom_api_download_image() call.

Rasmus