[PATCH v2 00/14] Correct confusing lmb error message

Simon Glass sjg at chromium.org
Fri Sep 1 03:13:38 CEST 2023


I ran into a very confusing error message about overlapping memory. I
found that the message is not correct, so this series refactors the lmb
code a little to permit the real message to be displayed, which is that
the internal lmb table has overflowed.

It also tidies up the code a little.

Feedback on the initial series showed some confusion between one type of
region and another. I had the same confusion, so this series renames the
inner 'region' to 'area'.

Changes in v2:
- Add new patch to rename region array to area
- Add new patch to rename memory/reserved_regions to area
- Add new patch to rename LMB_MAX_REGIONS and LMB_USE_MAX_REGIONS
- Add new patch to rename LMB_MAX_REGIONS and LMB_USE_MAX_REGIONS
- Add new patch to update use of region in the header file
- Add new patch to update use of region in the C file

Simon Glass (14):
  lmb: Drop surplus brackets and fix code style
  lmb: Rename interior piece to area
  lmb: Rename region array to area
  lmb: Rename memory/reserved_regions to area
  lmb: Rename LMB_MAX_REGIONS and LMB_USE_MAX_REGIONS
  lmb: Rename LMB_MAX_REGIONS and LMB_USE_MAX_REGIONS
  lmb: Update use of region in the header file
  lmb: Update use of region in the C file
  lmb: Tidy up structure access
  lmb: Avoid long for loop counters and function returns
  lmb: Change functions returning long to return int
  lmb: Tidy up lmb_overlaps_region()
  lmb: Document and tidy lmb_add_region_flags()
  fs: Fix a confusing error about overlapping regions

 configs/a3y17lte_defconfig           |   2 +-
 configs/a5y17lte_defconfig           |   2 +-
 configs/a7y17lte_defconfig           |   2 +-
 configs/apple_m1_defconfig           |   2 +-
 configs/dragonboard845c_defconfig    |   2 +-
 configs/mt7981_emmc_rfb_defconfig    |   2 +-
 configs/mt7981_rfb_defconfig         |   2 +-
 configs/mt7981_sd_rfb_defconfig      |   2 +-
 configs/mt7986_rfb_defconfig         |   2 +-
 configs/mt7986a_bpir3_emmc_defconfig |   2 +-
 configs/mt7986a_bpir3_sd_defconfig   |   2 +-
 configs/qcs404evb_defconfig          |   2 +-
 configs/starqltechn_defconfig        |   2 +-
 configs/stm32mp13_defconfig          |   6 +-
 configs/stm32mp15_basic_defconfig    |   6 +-
 configs/stm32mp15_defconfig          |   6 +-
 configs/stm32mp15_trusted_defconfig  |   6 +-
 configs/th1520_lpi4a_defconfig       |   2 +-
 fs/fs.c                              |   7 +-
 include/lmb.h                        | 105 ++++----
 lib/Kconfig                          |  30 +--
 lib/lmb.c                            | 349 +++++++++++++++------------
 test/cmd/bdinfo.c                    |   6 +-
 test/lib/lmb.c                       | 150 ++++++------
 24 files changed, 382 insertions(+), 317 deletions(-)

-- 
2.42.0.283.g2d96d420d3-goog



More information about the U-Boot mailing list