[PATCH v2] fpga: define dummy fpga_load function for debug build

Michal Simek michal.simek at amd.com
Fri Sep 1 08:31:12 CEST 2023



On 8/31/23 09:52, Chanho Park wrote:
> This fixes below build error when CC_OPTIMIZE_FOR_DEBUG is enabled and
> CONFIG_FPGA or CONFIG_SPL_FPGA are not enabled.
> When CC_OPTIMIZE_FOR_DEBUG is enabled, unused code will not be optimized
> out. Hence, fpga_load function must have a dummy implementation to avoid
> the build error.
> 
> ../common/spl/spl_fit.c:591: undefined reference to `fpga_load'
> collect2: error: ld returned 1 exit status
> 
> Signed-off-by: Chanho Park <chanho61.park at samsung.com>
> ---
> Change from v1:
> - Rewrite the commit message to include a CONFIG_FPGA
> 
>   include/fpga.h | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/include/fpga.h b/include/fpga.h
> index ed688cc0fa3b..44f2755a3f10 100644
> --- a/include/fpga.h
> +++ b/include/fpga.h
> @@ -60,8 +60,16 @@ int fpga_add(fpga_type devtype, void *desc);
>   int fpga_count(void);
>   const fpga_desc *const fpga_get_desc(int devnum);
>   int fpga_is_partial_data(int devnum, size_t img_len);
> +#if CONFIG_IS_ENABLED(FPGA)
>   int fpga_load(int devnum, const void *buf, size_t bsize,
>   	      bitstream_type bstype, int flags);
> +#else
> +static inline int fpga_load(int devnum, const void *buf, size_t bsize,
> +	      bitstream_type bstype, int flags)
> +{
> +	return FPGA_FAIL;
> +}
> +#endif
>   int fpga_fsload(int devnum, const void *buf, size_t size,
>   		fpga_fs_info *fpga_fsinfo);
>   int fpga_loads(int devnum, const void *buf, size_t size,

Applied.
M


More information about the U-Boot mailing list