[PATCH 4/5] xilinx: zynqmp: add Beckhoff CX8200

[Michal Simek]

On 8/30/23 16:03, Steffen Dirkwinkel wrote:
> From: Steffen Dirkwinkel <s.dirkwinkel at beckhoff.com>
> 
> This adds support for the Beckhoff CX8200 series of industrial embedded PCs.
> There is some information about the device and features here:
> https://www.beckhoff.com/en-en/products/ipc/embedded-pcs/cx8200-arm-cortex-a53/
> 
> Currently supported/tested:
> - Boot from microSD
> - Ethernet
> - USB
> - rtc / rtc eeprom
> - tpm access
> - uart
> 
> Open points:
> - adding the psgtr usb phy doesn't work in linux (failed to get pll
>    lock)
> - fpga loading currently only as u-boot script or pre launch cmd (type
>    may be stored in eeprom of rtc so this could be made generic)
> 
> Signed-off-by: Steffen Dirkwinkel <s.dirkwinkel at beckhoff.com>
> ---
> 
>   arch/arm/dts/Makefile                         |    1 +
>   arch/arm/dts/zynqmp-beckhoff-cx8200.dts       |  247 +++
>   .../zynqmp-beckhoff-cx8200/psu_init_gpl.c     | 1960 +++++++++++++++++
>   configs/xilinx_zynqmp_virt_defconfig          |    2 +-
>   4 files changed, 2209 insertions(+), 1 deletion(-)
>   create mode 100644 arch/arm/dts/zynqmp-beckhoff-cx8200.dts
>   create mode 100644 board/xilinx/zynqmp/zynqmp-beckhoff-cx8200/psu_init_gpl.c

First of all xilinx folder is not the right location because Xilinx/AMD is not 
manufacturer of this board.

Second I am normally pushing back on adding these custom boards because it just 
increase time for maintaining.
Your last commit was in 2019 but at least you have some commits that I can trust 
that you would maintain your board for some time.

My biggest question is in what category is your board unique that it should be 
added it to the tree?

Thanks,
Michal