[PATCH 1/2] thermal: k3-j72xx-bandgap: Add support for vtm

Kumar, Udit u-kumar1 at ti.com
Sat Sep 2 14:49:00 CEST 2023


Hi Nishanth,

On 9/2/2023 12:40 AM, Nishanth Menon wrote:
> On 23:43-20230901, Kumar, Udit wrote:
>> On 9/1/2023 11:03 PM, Nishanth Menon wrote:
>>> On 22:54-20230901, Kumar, Udit wrote:
>>>>>> +static const struct  udevice_id of_k3_j72xx_bandgap_match[] = {
>>>>>> +	{
>>>>>> +		.compatible = "ti,j721e-vtm",
>>>>>> +		.data = (ulong)&k3_j72xx_bandgap_j721e_data,
>>>>> So what happens to drivers/misc/k3_avs.c ?
>>>> Could you help me to understand this comment.
>>>>
>>>> Do you mean, why we can not add this support in AVS driver or
>>>>
>>>> need of this porting ?
>>>>
>>>> How I see, AVS driver to run at SPL/R5 time and this driver
>>>>
>>>> to be probed in Main/A72 u-boot when needed.
>>> you are saying the drivers are mutually exclusive - how about detecting
>>> over-temp scenario at R5 boot? switching on A53 will be a mistake at
>>> that point, no?
>> Yes these are  mutually exclusive.
>>
>> Let me see, how I can add TSHUT value programming in avs driver to avoid
>> above.
>>
>> But in case, temperature reading is needed from u-boot shell, we still need
>> this code.
> One approach might be to merge the two.

I think merging of these two feature could be done in one file, as one 
driver or two.

But on execution/feature side, from R5/SPL we need to set voltage for 
A72 (OPP or AVS)  before

releasing A72 core. Also can program TSHUT value for thermal overrun 
protection.

For A72/Main u-boot, provide function of temperature reporting from shell.



More information about the U-Boot mailing list