[PATCH 2/2] doc: rockchip: Update and complete info about RK3308

[Massimo Pegorer]

Hi Johan,

Il giorno dom 3 set 2023 alle ore 10:36 Johan Jonker
<jbx6244 at gmail.com> ha scritto:
>
>
>
> On 9/2/23 18:32, Massimo Pegorer wrote:
> > Update documentation about build steps for RK3308, using an external
> > TPL. Add RK3308 case to rST document. Add ROCK Pi S in the list of
> > supported boards.
> >
> > Signed-off-by: Massimo Pegorer <massimo.pegorer+oss at gmail.com>
> > ---
> >  doc/README.rockchip             |  4 ++--
> >  doc/board/rockchip/rockchip.rst | 10 ++++++++++
> >  2 files changed, 12 insertions(+), 2 deletions(-)
> >
> > diff --git a/doc/README.rockchip b/doc/README.rockchip
> > index 52b5140eca..cfbd858c3b 100644
> > --- a/doc/README.rockchip
> > +++ b/doc/README.rockchip
> > @@ -38,16 +38,16 @@ Building
> >      (or you can use another cross compiler if you prefer)
> >
>
> >  2. To build RK3308 board:
> > +
> >     - Get the rkbin
> >       => git clone https://github.com/rockchip-linux/rkbin.git
> >
> >     - Compile U-Boot
> >       => cd /path/to/u-boot
> >       => export BL31=/path/to/rkbin/bin/rk33/rk3308_bl31_v2.22.elf
> > +     => export ROCKCHIP_TPL=/path/to/rkbin/bin/rk33/rk3308_ddr_589MHz_uart2_m0_v1.26.bin
> >       => make roc-cc-rk3308_defconfig
> >       => make CROSS_COMPILE=aarch64-linux-gnu- all
> > -     => ./tools/mkimage -n rk3308 -T rksd -d /path/to/rkbin/bin/rk33/rk3308_ddr_589MHz_uart2_m0_v1.26.bin idbloader.img
> > -     => cat spl/u-boot-spl.bin  >> idbloader.img
> >
>
> Hi Massimo,
>
> The text in this document should moved to doc/board/rockchip.
> This paragraph above is therefor redundant, so it can be removed I think.
>
> Johan

OK, thanks, I agree on redundant. But I do not know if everything here
- other than RK3308 info - has already been moved to
doc/board/rockchip.rst, so to remove it. On the other hand, leaving as
it is (i.e. not updated) would be misleading.

If everybody agree I can remove it in a V2, or otherwise just delete
the RK3308 section.

Massimo

> >  3. To build RK3399 board:
> >
> > diff --git a/doc/board/rockchip/rockchip.rst b/doc/board/rockchip/rockchip.rst
> > index de9fe8e642..b38c3d3136 100644
> > --- a/doc/board/rockchip/rockchip.rst
> > +++ b/doc/board/rockchip/rockchip.rst
> > @@ -53,6 +53,7 @@ List of mainline supported Rockchip boards:
> >       - Google Speedy (chromebook_speedy)
> >       - Amarula Vyasa-RK3288 (vyasa-rk3288)
> >  * rk3308
> > +     - Radxa ROCK Pi S (rock-pi-s-rk3308)
> >       - Rockchip Evb-RK3308 (evb-rk3308)
> >       - Roc-cc-RK3308 (roc-cc-rk3308)
> >  * rk3326
> > @@ -172,6 +173,15 @@ To build rk3288 boards:
> >          make evb-rk3288_defconfig
> >          make CROSS_COMPILE=arm-linux-gnueabihf-
> >
> > +To build rk3308 boards:
> > +
> > +.. code-block:: bash
> > +
> > +        export BL31=../rkbin/bin/rk33/rk3308_bl31_vX.YZ.elf
> > +        export ROCKCHIP_TPL=../rkbin/bin/rk33/rk3308_ddr_589MHz_uart0_m0_vX.YZ.bin
> > +        make evb-rk3308_defconfig
> > +        make CROSS_COMPILE=aarch64-linux-gnu-
> > +
> >  To build rk3328 boards:
> >
> >  .. code-block:: bash