[PATCH 3/8] x86: samus_tpl: Correct text base and alloc sizes

Bin Meng bmeng.cn at gmail.com
Mon Sep 4 11:21:53 CEST 2023


Hi Simon,

On Thu, Aug 24, 2023 at 2:48 AM Simon Glass <sjg at chromium.org> wrote:
>
> Make sure that CONFIG_TEXT_BASE is the same as CONFIG_X86_OFFSET_U_BOOT

The commit message should say:

Make sure that CONFIG_X86_OFFSET_U_BOOT is the same as
CONFIG_TEXT_BASE as it is changing CONFIG_X86_OFFSET_U_BOOT.

> since this boards boots into U-Boot proper in flash, not RAM. Also exapnd

s/boards/board

typo: expand

> the SPL malloc() size a little, to avoid an error.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
>  configs/chromebook_samus_tpl_defconfig | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/configs/chromebook_samus_tpl_defconfig b/configs/chromebook_samus_tpl_defconfig
> index 4cfaf4bc5c7..6fefe2ddc25 100644
> --- a/configs/chromebook_samus_tpl_defconfig
> +++ b/configs/chromebook_samus_tpl_defconfig
> @@ -1,6 +1,8 @@
>  CONFIG_X86=y
>  CONFIG_TEXT_BASE=0xffed0000
>  CONFIG_SYS_MALLOC_F_LEN=0x2000
> +CONFIG_TPL_SYS_MALLOC_F_LEN=0x2000
> +CONFIG_SPL_SYS_MALLOC_F_LEN=0x3000
>  CONFIG_NR_DRAM_BANKS=8
>  CONFIG_ENV_SIZE=0x1000
>  CONFIG_ENV_OFFSET=0x3F8000
> @@ -19,7 +21,7 @@ CONFIG_HAVE_MRC=y
>  CONFIG_HAVE_REFCODE=y
>  CONFIG_SMP=y
>  CONFIG_HAVE_VGA_BIOS=y
> -CONFIG_X86_OFFSET_U_BOOT=0xffee0000
> +CONFIG_X86_OFFSET_U_BOOT=0xffed0000
>  CONFIG_SYS_MONITOR_BASE=0xFFED0000
>  CONFIG_BOOTSTAGE=y
>  CONFIG_BOOTSTAGE_REPORT=y
> --

Otherwise,
Reviewed-by: Bin Meng <bmeng.cn at gmail.com>

Regards,
Bin


More information about the U-Boot mailing list