[PATCH 1/3] xilinx: versal-net: Do not setup boot_targets if driver is not enabled

Michal Simek michal.simek at amd.com
Tue Sep 5 11:51:29 CEST 2023



On 9/4/23 16:43, Simon Glass wrote:
> Hi Venkatesh,
> 
> On Mon, 4 Sept 2023 at 07:58, Venkatesh Yadav Abbarapu
> <venkatesh.abbarapu at amd.com> wrote:
>>
>> SOC can boot in the device which is not accessible from APU and running
>> this is detected as error which ends up in stopping boot process.
>> Boot mode detection and logic around is present to setup priority
>> on boot devices that SOC boot device is likely also used for booting OS.
>> Change logic to detect this case with showing message about it but don't
>> fail in boot process and don't prioritize boot device in this case.
>>
>> Signed-off-by: Michal Simek <michal.simek at amd.com>
>> Signed-off-by: Venkatesh Yadav Abbarapu <venkatesh.abbarapu at amd.com>
>> ---
>>   board/xilinx/versal-net/board.c | 76 ++++++++++++++++-----------------
>>   1 file changed, 38 insertions(+), 38 deletions(-)
>>
> 
> If you switch to standard boot it won't try to boot on devices which
> don't exist.

Actually I was looking at standard boot yesterday. We have enabled standard boot 
already but not BOOTSTD_FULL because there is a dependency on having video 
enabled. Actually this dependency should be covered in Kconfig too.

I don't think this is an issue with this series which is trying to address issue 
properly. But let me send a patch to guard this code only when 
CONFIG_DISTRO_DEFAULTS is enabled. And also that huge amount of variables don't 
need to be created too in this case.

Thanks,
Michal


More information about the U-Boot mailing list