[RFC 4/6] gpio: add scmi driver based on pinctrl

Michal Simek michal.simek at amd.com
Wed Sep 6 16:56:56 CEST 2023



On 9/6/23 04:40, AKASHI Takahiro wrote:
> This DM-compliant driver deals with SCMI pinctrl protocol and presents
> gpio devices exposed by SCMI firmware (server).
> 
> Signed-off-by: AKASHI Takahiro <takahiro.akashi at linaro.org>
> ---
>   drivers/pinctrl/pinctrl-scmi.c | 544 ++++++++++++++++++++++++++++++++-
>   1 file changed, 539 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-scmi.c b/drivers/pinctrl/pinctrl-scmi.c
> index 3ebdad57b86c..73d385bdbfcc 100644
> --- a/drivers/pinctrl/pinctrl-scmi.c
> +++ b/drivers/pinctrl/pinctrl-scmi.c
> @@ -11,21 +11,20 @@
>   #include <malloc.h>
>   #include <scmi_agent.h>
>   #include <scmi_protocols.h>
> +#include <asm-generic/gpio.h>
>   #include <dm/device_compat.h>
> +#include <dm/device-internal.h>
> +#include <dm/lists.h>
>   #include <dm/pinctrl.h>
>   
>   /**
>    * struct scmi_pin - attributes for a pin
>    * @name:	Name of pin
> - * @value:	Value of pin
> - * @flags:	A set of flags
>    * @function:	Function selected
>    * @status:	An array of status of configuration types
>    */
>   struct scmi_pin {
>   	char		*name;
> -	u32		value;
> -	u32		flags;


You have added this in 3/6 then there is no reason to remove it in this version.

M


More information about the U-Boot mailing list