[PATCH v2 3/7] arm: mach-k3: j721e_init: Move clk_k3 probe before loading TIFS
Nishanth Menon
nm at ti.com
Thu Sep 7 17:03:01 CEST 2023
On 19:44-20230907, Neha Malcom Francis wrote:
> Since we need to configure required clocks before TIFS is loaded, move
> clk_k3 driver probe before k3_sysfw_loader.
This needs further elaboration. what kind of clocks are we talking
about? what is the call sequence that is involved that this is solving?
>
> Signed-off-by: Neha Malcom Francis <n-francis at ti.com>
> ---
> arch/arm/mach-k3/j721e_init.c | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/arch/arm/mach-k3/j721e_init.c b/arch/arm/mach-k3/j721e_init.c
> index b6164575b7..b1f7e25ed0 100644
> --- a/arch/arm/mach-k3/j721e_init.c
> +++ b/arch/arm/mach-k3/j721e_init.c
> @@ -228,6 +228,18 @@ void board_init_f(ulong dummy)
> if (!ret)
> pinctrl_select_state(dev, "default");
>
> + /*
> + * Force probe of clk_k3 driver here to ensure basic default clock
> + * configuration is always done.
> + */
> + if (IS_ENABLED(CONFIG_SPL_CLK_K3)) {
> + ret = uclass_get_device_by_driver(UCLASS_CLK,
> + DM_DRIVER_GET(ti_clk),
> + &dev);
> + if (ret)
> + panic("Failed to initialize clk-k3!\n");
> + }
> +
> /*
> * Load, start up, and configure system controller firmware. Provide
> * the U-Boot console init function to the SYSFW post-PM configuration
> @@ -241,18 +253,6 @@ void board_init_f(ulong dummy)
> do_dt_magic();
> #endif
>
> - /*
> - * Force probe of clk_k3 driver here to ensure basic default clock
> - * configuration is always done.
> - */
> - if (IS_ENABLED(CONFIG_SPL_CLK_K3)) {
> - ret = uclass_get_device_by_driver(UCLASS_CLK,
> - DM_DRIVER_GET(ti_clk),
> - &dev);
> - if (ret)
> - panic("Failed to initialize clk-k3!\n");
> - }
> -
> /* Prepare console output */
> preloader_console_init();
>
> --
> 2.34.1
>
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
More information about the U-Boot
mailing list