[PATCHv7 00/15] net/lwip: add lwip library for the network stack
Michal Simek
monstr at monstr.eu
Thu Sep 7 17:21:18 CEST 2023
Hi,
út 22. 8. 2023 v 11:38 odesílatel Maxim Uvarov <maxim.uvarov at linaro.org> napsal:
>
> Hello,
>
> I'm sending v7, with all v6 comments getting fixed. The only thing left is a pointer
> to timeout callback which 2 applications use. I will rework this timeout
> in next v8. I started take a look at it, and want to fix this together
> with background applications support in v8.
>
> changelog:
> v7: - more review fixes.
> - support of multiply eth devices, were "ethact" selects the
> active device.
> v6: - fixed review comments for v5 (thanks Ilias and Simon).
> - lwip is not under /net, so prior applying patch following
> commit is needed to create lwIP merge into U-Boot:
> git subtree add --prefix net/lwip/lwip-external https://git.savannah.nongnu.org/git/lwip.git master --squash
I think you should integrate it via .gitmodules as is done for example in qemu.
The next part. I tried to use buildmain to build the whole series and
I am getting a lot of errors.
You should fix pretty much all of these errors to make sure that the
tree is bisectable.
Thanks,
Michal
[u-boot](lwip)$ ./tools/buildman/buildman -C -b `git rev-parse
--abbrev-ref HEAD` xilinx_zynqmp_virt -o /run/shm/ -sSed
Summary of 18 commits for 1 boards (1 thread, 12 jobs per thread)
01: Merge branch 'master' of https://gitlab.denx.de/u-boot/custodians/u-boot-usb
aarch64: w+ xilinx_zynqmp_virt
+===================== WARNING ======================
+This board uses CONFIG_SPL_FIT_GENERATOR. Please migrate
+to binman instead, to avoid the proliferation of
+arch-specific scripts with no tests.
+====================================================
02: net/lwip: add doc/develop/net_lwip.rst
03: net/lwip: integrate lwIP library
aarch64: + xilinx_zynqmp_virt
-===================== WARNING ======================
-This board uses CONFIG_SPL_FIT_GENERATOR. Please migrate
-to binman instead, to avoid the proliferation of
-arch-specific scripts with no tests.
-====================================================
+make[3]: *** No rule to make target
'net/lwip/lwip-external/src/core/init.o', needed by
'net/lwip/built-in.o'. Stop.
+make[2]: *** [../scripts/Makefile.build:397: net/lwip] Error 2
+../net/net.c:128:23: fatal error: net/ulwip.h: No such file or directory
+ #include <net/ulwip.h>
+ ^
+compilation terminated.
+make[2]: *** [../scripts/Makefile.build:256: net/net.o] Error 1
+make[1]: *** [Makefile:1857: net] Error 2
+make: *** [Makefile:177: sub-make] Error 2
04: net/lwip: implement dns cmd
-make[2]: *** [../scripts/Makefile.build:256: net/net.o] Error 1
+make[2]: *** [../scripts/Makefile.build:257: net/net.o] Error 1
05: net/lwip: implement dhcp cmd
06: net/lwip: implement tftp cmd
+cp: cannot stat '../net/lwip/lwip-external/src/apps/tftp/tftp.c': No
such file or directory
+make[4]: *** [../net/lwip/apps/tftp/Makefile:9:
net/lwip/apps/tftp/tftp.c] Error 1
+../net/lwip/apps/tftp/lwip-tftp.c:12:35: fatal error:
lwip/apps/tftp_client.h: No such file or directory
+ #include "lwip/apps/tftp_client.h"
+ ^
+make[4]: *** [../scripts/Makefile.build:257:
net/lwip/apps/tftp/lwip-tftp.o] Error 1
+make[3]: *** [../scripts/Makefile.build:397: net/lwip/apps/tftp] Error 2
07: net/lwip: implement wget cmd
08: net/lwip: implement ping cmd
+cp: cannot stat '../net/lwip/lwip-external/contrib/apps/ping/ping.c':
No such file or directory
+make[4]: *** [../net/lwip/apps/ping/Makefile:8:
net/lwip/apps/ping/ping.c] Error 1
+../net/lwip/apps/ping/lwip_ping.c:7:22: fatal error: lwip/opt.h: No
such file or directory
+ #include "lwip/opt.h"
+ ^
+make[4]: *** [../scripts/Makefile.build:257:
net/lwip/apps/ping/lwip_ping.o] Error 1
+make[3]: *** [../scripts/Makefile.build:397: net/lwip/apps/ping] Error 2
09: net/lwip: add lwIP configuration
10: net/lwip: implement lwIP port to U-Boot
-../net/lwip/apps/ping/lwip_ping.c:7:22: fatal error: lwip/opt.h: No
such file or directory
- #include "lwip/opt.h"
- ^
-make[4]: *** [../scripts/Makefile.build:257:
net/lwip/apps/ping/lwip_ping.o] Error 1
-../net/lwip/apps/tftp/lwip-tftp.c:12:35: fatal error:
lwip/apps/tftp_client.h: No such file or directory
- #include "lwip/apps/tftp_client.h"
- ^
-make[4]: *** [../scripts/Makefile.build:257:
net/lwip/apps/tftp/lwip-tftp.o] Error 1
+../net/eth-uclass.c:35:2: error: unknown type name ‘ulwip’
+ ulwip ulwip;
+ ^~~~~
+ return &priv->ulwip;
+ ^~~~~~~~~~~~
+make[2]: *** [../scripts/Makefile.build:257: net/eth-uclass.o] Error 1
w+../net/eth-uclass.c: In function ‘eth_lwip_priv’:
w+../net/eth-uclass.c:355:9: warning: return from incompatible pointer
type [-Wincompatible-pointer-types]
11: net/lwip: update .gitignore with lwIP
+../net/lwip/apps/ping/lwip_ping.c:7:22: fatal error: lwip/opt.h: No
such file or directory
+ #include "lwip/opt.h"
+ ^
+make[4]: *** [../scripts/Makefile.build:257:
net/lwip/apps/ping/lwip_ping.o] Error 1
+../net/lwip/apps/tftp/lwip-tftp.c:12:35: fatal error:
lwip/apps/tftp_client.h: No such file or directory
+ #include "lwip/apps/tftp_client.h"
+ ^
+make[4]: *** [../scripts/Makefile.build:257:
net/lwip/apps/tftp/lwip-tftp.o] Error 1
12: net/lwip: connection between cmd and lwip apps
-../net/lwip/apps/ping/lwip_ping.c:7:22: fatal error: lwip/opt.h: No
such file or directory
- #include "lwip/opt.h"
- ^
-make[4]: *** [../scripts/Makefile.build:257:
net/lwip/apps/ping/lwip_ping.o] Error 1
-../net/lwip/apps/tftp/lwip-tftp.c:12:35: fatal error:
lwip/apps/tftp_client.h: No such file or directory
- #include "lwip/apps/tftp_client.h"
- ^
-make[4]: *** [../scripts/Makefile.build:257:
net/lwip/apps/tftp/lwip-tftp.o] Error 1
+../cmd/net-lwip.c:16:23: fatal error: net/ulwip.h: No such file or directory
+ #include "net/ulwip.h"
+make[2]: *** [../scripts/Makefile.build:257: cmd/net-lwip.o] Error 1
+make[1]: *** [Makefile:1857: cmd] Error 2
13: net/lwip: replace original net commands with lwip
-make[3]: *** No rule to make target
'net/lwip/lwip-external/src/core/init.o', needed by
'net/lwip/built-in.o'. Stop.
-cp: cannot stat '../net/lwip/lwip-external/src/apps/tftp/tftp.c': No
such file or directory
-make[4]: *** [../net/lwip/apps/tftp/Makefile:9:
net/lwip/apps/tftp/tftp.c] Error 1
-make[3]: *** [../scripts/Makefile.build:397: net/lwip/apps/tftp] Error 2
-../cmd/net-lwip.c:16:23: fatal error: net/ulwip.h: No such file or directory
- #include "net/ulwip.h"
- ^
-compilation terminated.
-make[2]: *** [../scripts/Makefile.build:257: cmd/net-lwip.o] Error 1
-make[1]: *** [Makefile:1857: cmd] Error 2
-make[2]: *** [../scripts/Makefile.build:257: net/eth-uclass.o] Error 1
-../net/net.c:128:23: fatal error: net/ulwip.h: No such file or directory
- #include <net/ulwip.h>
-make[2]: *** [../scripts/Makefile.build:257: net/net.o] Error 1
+make[2]: *** [../scripts/Makefile.build:256: net/eth-uclass.o] Error 1
14: net/lwip: split net.h to net.h, arp.h and eth.h
-../net/eth-uclass.c:35:2: error: unknown type name ‘ulwip’
- ulwip ulwip;
- ^~~~~
- return &priv->ulwip;
- ^~~~~~~~~~~~
-make[2]: *** [../scripts/Makefile.build:256: net/eth-uclass.o] Error 1
w-../net/eth-uclass.c: In function ‘eth_lwip_priv’:
w-../net/eth-uclass.c:355:9: warning: return from incompatible pointer
type [-Wincompatible-pointer-types]
15: net/lwip: drop old net/wget
+make[3]: *** No rule to make target
'net/lwip/lwip-external/src/core/init.o', needed by
'net/lwip/built-in.o'. Stop.
+cp: cannot stat '../net/lwip/lwip-external/src/apps/tftp/tftp.c': No
such file or directory
+make[4]: *** [../net/lwip/apps/tftp/Makefile:9:
net/lwip/apps/tftp/tftp.c] Error 1
+../net/lwip/apps/ping/lwip_ping.c:7:22: fatal error: lwip/opt.h: No
such file or directory
+ #include "lwip/opt.h"
+ ^
+compilation terminated.
+make[4]: *** [../scripts/Makefile.build:257:
net/lwip/apps/ping/lwip_ping.o] Error 1
+../net/lwip/apps/tftp/lwip-tftp.c:12:35: fatal error:
lwip/apps/tftp_client.h: No such file or directory
+ #include "lwip/apps/tftp_client.h"
+ ^
+make[4]: *** [../scripts/Makefile.build:257:
net/lwip/apps/tftp/lwip-tftp.o] Error 1
+make[3]: *** [../scripts/Makefile.build:397: net/lwip/apps/tftp] Error 2
16: net/lwip/wget add port selection
17: Squashed 'net/lwip/lwip-external/' content from commit 84fde1ebbfe3
-make[3]: *** No rule to make target
'net/lwip/lwip-external/src/core/init.o', needed by
'net/lwip/built-in.o'. Stop.
-cp: cannot stat '../net/lwip/lwip-external/contrib/apps/ping/ping.c':
No such file or directory
-make[4]: *** [../net/lwip/apps/ping/Makefile:8:
net/lwip/apps/ping/ping.c] Error 1
-cp: cannot stat '../net/lwip/lwip-external/src/apps/tftp/tftp.c': No
such file or directory
-make[4]: *** [../net/lwip/apps/tftp/Makefile:9:
net/lwip/apps/tftp/tftp.c] Error 1
-../net/lwip/apps/ping/lwip_ping.c:7:22: fatal error: lwip/opt.h: No
such file or directory
- #include "lwip/opt.h"
- ^
-compilation terminated.
-make[4]: *** [../scripts/Makefile.build:257:
net/lwip/apps/ping/lwip_ping.o] Error 1
-make[3]: *** [../scripts/Makefile.build:397: net/lwip/apps/ping] Error 2
-../net/lwip/apps/tftp/lwip-tftp.c:12:35: fatal error:
lwip/apps/tftp_client.h: No such file or directory
- #include "lwip/apps/tftp_client.h"
- ^
-make[4]: *** [../scripts/Makefile.build:257:
net/lwip/apps/tftp/lwip-tftp.o] Error 1
-make[3]: *** [../scripts/Makefile.build:397: net/lwip/apps/tftp] Error 2
-make[2]: *** [../scripts/Makefile.build:397: net/lwip] Error 2
-make[1]: *** [Makefile:1857: net] Error 2
-make: *** [Makefile:177: sub-make] Error 2
+make: *** No rule to make target 'xilinx_zynqmp_virt_defconfig'. Stop.
18: Merge commit 'c773d79082011e8d77cd4b125c07a84b8348af39' as
'net/lwip/lwip-external'
aarch64: w+ xilinx_zynqmp_virt
-make: *** No rule to make target 'xilinx_zynqmp_virt_defconfig'. Stop.
+===================== WARNING ======================
+This board uses CONFIG_SPL_FIT_GENERATOR. Please migrate
+to binman instead, to avoid the proliferation of
+arch-specific scripts with no tests.
+====================================================
More information about the U-Boot
mailing list