[PATCH v2 1/7] drivers: misc: k3_avs: Add linux compatible to maintain sync

Neha Malcom Francis n-francis at ti.com
Fri Sep 8 04:57:28 CEST 2023


Hi Reid

On 07/09/23 23:39, reidt wrote:
> On 10:08-20230907, Nishanth Menon wrote:
>> On 19:44-20230907, Neha Malcom Francis wrote:
>>> The U-Boot AVS driver works on the VTM (Voltage and Thermal Management)
>>> module, also used by the Linux TI Bandgap temperature sensor driver
>>> (drivers/thermal/k3_j72xx_bandgap.c). Although the purpose and
>>> functionalities that these two implement are different, the hardware is
>>> the same, so ensure that their compatibles are in sync. Thus, add
>>> ti,j721e-vtm compatible to the AVS driver.
>>>
>>> Signed-off-by: Neha Malcom Francis <n-francis at ti.com>
>>> ---
>>>   drivers/misc/k3_avs.c | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/misc/k3_avs.c b/drivers/misc/k3_avs.c
>>> index 840148d090..3008cf9810 100644
>>> --- a/drivers/misc/k3_avs.c
>>> +++ b/drivers/misc/k3_avs.c
>>> @@ -382,6 +382,7 @@ static struct vd_config am654_vd_config = {
>>>   static const struct udevice_id k3_avs_ids[] = {
>>>   	{ .compatible = "ti,am654-avs", .data = (ulong)&am654_vd_config },
>>>   	{ .compatible = "ti,j721e-avs", .data = (ulong)&j721e_vd_config },
>>> +	{ .compatible = "ti,j721e-vtm", .data = (ulong)&j721e_vd_config },
>>>   	{}
>>>   };
>>>   
>>> -- 
>>> 2.34.1
>>>
>> https://lore.kernel.org/all/52a7c0b2-7a87-c74e-e63f-d07821ffc1f8@ti.com/
>>
>> we are going to end up creating a dependency nightmare.
>>
>> Can we just do a single series(might be just a single patch) for
>> compatible additions for k3_avs.c and make the dts syncs dependent on this?
>>
> 
> I submitted one here if this works:
> https://lore.kernel.org/u-boot/20230907180635.89011-1-reidt@ti.com/T/#u
> 
> -Reid
> 

Thanks for sending the patch! I'll omit this patch from the next version.

>> -- 
>> Regards,
>> Nishanth Menon
>> Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

-- 
Thanking You
Neha Malcom Francis


More information about the U-Boot mailing list