[PATCHv7 00/15] net/lwip: add lwip library for the network stack

[Michal Simek]

On 9/7/23 21:23, Tom Rini wrote:
> On Thu, Sep 07, 2023 at 05:21:18PM +0200, Michal Simek wrote:
>> Hi,
>>
>> út 22. 8. 2023 v 11:38 odesílatel Maxim Uvarov <maxim.uvarov at linaro.org> napsal:
>>>
>>> Hello,
>>>
>>> I'm sending v7, with all v6 comments getting fixed. The only thing left is a pointer
>>> to timeout callback which 2 applications use. I will rework this timeout
>>> in next v8. I started take a look at it, and want to fix this together
>>> with background applications support in v8.
>>>
>>> changelog:
>>>          v7: - more review fixes.
>>>              - support of multiply eth devices, were "ethact" selects the
>>>                active device.
>>>          v6: - fixed review comments for v5 (thanks Ilias and Simon).
>>>              - lwip is not under /net, so prior applying patch following
>>>                commit is needed to create lwIP merge into U-Boot:
>>>                git subtree add --prefix net/lwip/lwip-external https://git.savannah.nongnu.org/git/lwip.git master --squash
>>
>> I think you should integrate it via .gitmodules as is done for example in qemu.
> 
> I _think_ I am leaning towards subtree, but it sounds like we need to
> make the initial build easier, perhaps some Makefile logic to see we
> haven't added, and then do what's needed?
> 

Definitely it has to solved without any manual step. And this is enabled by 
default for all platforms. I pretty much think that it should be disabled now 
and when tested properly it can become default y.

Thanks,
Michal