[PATCH 3/8] binman: capsule: Generate capsules through config file

[Simon Glass]

Hi Sughosh,

On Fri, 8 Sept 2023 at 06:00, Sughosh Ganu <sughosh.ganu at linaro.org> wrote:
>
> Add support in binman for generating capsules by reading the capsule
> parameters through a config file. Also add a test case in binman for
> this mode of capsule generation.
>
> Signed-off-by: Sughosh Ganu <sughosh.ganu at linaro.org>
> ---
>
>  tools/binman/entries.rst                   | 35 ++++++++++++
>  tools/binman/etype/efi_capsule_cfg_file.py | 66 ++++++++++++++++++++++
>  tools/binman/ftest.py                      | 29 ++++++++++
>  tools/binman/test/319_capsule_cfg.dts      | 15 +++++
>  4 files changed, 145 insertions(+)
>  create mode 100644 tools/binman/etype/efi_capsule_cfg_file.py
>  create mode 100644 tools/binman/test/319_capsule_cfg.dts

I think we discussed this some time ago. The problem I have with this
is that it adds another way of specifying the image description,
separate from the binman definition. This introduces all sorts of
problems:

- the question of where the filenames are located, something which
binman tries to handle cohesively
- binman has no knowledge of what is being put in the capsules
- the resulting fdtmap lacks any information about what is in the capsules
- it seems to create two ways of doing the same thing

Binman can presumably already create multiple capsule files, just by
adding to the description.

What need does this feature meet?

Regards,
Simon