Aw: [PATCH v3] board: rockchip: Add Bananapi R2Pro Board

[Marek Vasut]

On 9/16/23 18:45, Frank Wunderlich wrote:
> Am 16. September 2023 18:07:44 MESZ schrieb Marek Vasut <marex at denx.de>:
>> On 9/16/23 16:18, Frank Wunderlich wrote:
>>> Hi,
>>>
>>> just a friedly reminder. would be great if it can be merged in next uboot-version.
>>
>> +CC Tom
>>
>>> regards Frank
>>>
>>>
>>>> Gesendet: Sonntag, 20. August 2023 um 18:00 Uhr
>>>> Von: "Frank Wunderlich" <linux at fw-web.de>
>>>> An: u-boot at lists.denx.de
>>>> Cc: "Frank Wunderlich" <frank-w at public-files.de>, "Simon Glass" <sjg at chromium.org>, "Philipp Tomsich" <philipp.tomsich at vrull.eu>, "Kever Yang" <kever.yang at rock-chips.com>, "Marek Vasut" <marex at denx.de>, "Jonas Karlman" <jonas at kwiboo.se>
>>>> Betreff: [PATCH v3] board: rockchip: Add Bananapi R2Pro Board
>>>>
>>>> From: Frank Wunderlich <frank-w at public-files.de>
>>>>
>>>> Add Bananapi R2 Pro board.
>>>>
>>>> Till now evb dts could be used, but iodomain is different
>>>> (evb has 1v8 on vccio2 and vccio4 which are 3v3 on r2pro)
>>>> and with iodomain driver this can cause hardware fault.
>>>>
>>>> Devicetree in mainline-Linux:
>>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
>>
>> What would be real helpful is a commit ID from which the DT was copied , so it can be easily updated in the future.
> 
> It is no plain copy...i removed parts not relevant for uboot now (from current linux version).

Ouch, please don't do that. Instead, if you really do need to drop some 
nodes from U-Boot control DT, say board.dts, introduce new file called 
board-u-boot.dtsi and add '/delete-node/ &the_node_to_remove;' lines to 
remove nodes while DTC is processing the DT into .dtb .

This way, the imported board.dts from Linux can be later synchronized 
with newer version of Linux DT, and the U-Boot specific changes are in a 
separate file.

The U-Boot build system will first concatenate the files, i.e. cat 
board.dts board-u-boot.dtsi > temp.dts and then run DTC on the temp.dts 
, so whatever changes you do in the board-u-boot.dtsi will be processed 
after the original board.dts is processed by DTC (DTC processes the 
input DTS in order).

> E.g. switch driver is currently bundled in mtk ethernet driver and using different devicetree structure than linux dsa driver. We have to separate it before we can use it on r2pro. But this will take some time...also pcie(-phy) does not have a driver yet,so before adding dead code i dropped these parts for now.

See above, that should do the trick.