[RESEND PATCH v1 2/2] clk: Add clock driver for Amlogic A1

[Igor Prusov]

Hi Simon, 

On Mon, Sep 18, 2023 at 07:04:47PM -0600, Simon Glass wrote:
> On Sun, 17 Sept 2023 at 04:14, Igor Prusov <ivprusov at salutedevices.com> wrote:
> >
> > This patch adds basic clock driver for Amlogic A1 Family which supports
> > enabling/disabling some gates, getting frequencies and setting rate
> > with limited reparenting.
> >
> > Signed-off-by: Igor Prusov <ivprusov at salutedevices.com>
> > ---
> >  arch/arm/include/asm/arch-meson/clock-a1.h |  23 +
> >  drivers/clk/meson/Kconfig                  |   8 +
> >  drivers/clk/meson/Makefile                 |   1 +
> >  drivers/clk/meson/a1.c                     | 681 +++++++++++++++++++++
> >  4 files changed, 713 insertions(+)
> >  create mode 100644 arch/arm/include/asm/arch-meson/clock-a1.h
> >  create mode 100644 drivers/clk/meson/a1.c
> 
> Reviewed-by: Simon Glass <sjg at chromium.org>
> 
> This could use a few more comments, IMO.
Sure, I can add some more comments in V2. 

> Did it come from Linux?
No, I wrote this specifically for u-boot. I initally was looking at
other drivers in clk/meson/ for reference, but decided to go for
something like clk_k210 driver to separate clocks topology and ops
implementation. These clocks were added to Linux in [1], but AFAIU we
can't simply re-use Linux clock drivers and get working rate
propogation, reparenting e.t.c.

[1]: https://lore.kernel.org/all/20230523135351.19133-1-ddrokosov@sberdevices.ru/

-- 
Best Regards,
Igor Prusov