[PATCH v5 08/20] x86: coreboot: Drop USB init on startup

[Heinrich Schuchardt]

On 9/20/23 05:00, Simon Glass wrote:
> This is very annoying as it is quite slow on many machines. Also, U-Boot
> has an existing 'preboot' mechanism to enable this feature if desired.
>
> Drop this code so that it is possible to choose whether to init USB or
> not.
>
> Use the existing USE_PREBOOT mechanism instead.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
> Changes in v5:
> - Make use of the uSE_PREBOOT mechanism
>
>   arch/x86/cpu/coreboot/Kconfig    | 1 +
>   arch/x86/cpu/coreboot/coreboot.c | 4 ----
>   2 files changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/arch/x86/cpu/coreboot/Kconfig b/arch/x86/cpu/coreboot/Kconfig
> index b97c27790419..178f8ad18162 100644
> --- a/arch/x86/cpu/coreboot/Kconfig
> +++ b/arch/x86/cpu/coreboot/Kconfig
> @@ -25,6 +25,7 @@ config SYS_COREBOOT
>   	imply FS_CBFS
>   	imply CBMEM_CONSOLE
>   	imply X86_TSC_READ_BASE
> +	imply USE_PREBOOT

For automatic initialization of the PCI bus we have CONFIG_PCI_INIT_R.
Wouldn't it be preferable to also have a CONFIG_USB_INIT_R instead of
relying on console commands in CONFIG_PREBOOT?

Best regards

Heinrich

>   	select BINMAN if X86_64
>
>   endif
> diff --git a/arch/x86/cpu/coreboot/coreboot.c b/arch/x86/cpu/coreboot/coreboot.c
> index da43d66e95d7..82fe4c71cd27 100644
> --- a/arch/x86/cpu/coreboot/coreboot.c
> +++ b/arch/x86/cpu/coreboot/coreboot.c
> @@ -86,10 +86,6 @@ static int last_stage_init(void)
>   	if (IS_ENABLED(CONFIG_SPL_BUILD))
>   		return 0;
>
> -	/* start usb so that usb keyboard can be used as input device */
> -	if (IS_ENABLED(CONFIG_USB_KEYBOARD))
> -		usb_init();
> -
>   	board_final_init();
>
>   	return 0;